Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image animations / remove fading when switching between local and remote echoes. #3525

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from pixlwave November 18, 2024 12:34
@stefanceriu stefanceriu requested a review from a team as a code owner November 18, 2024 12:34
Copy link

github-actions bot commented Nov 18, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e4d5584

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Nov 18, 2024
@stefanceriu stefanceriu enabled auto-merge (rebase) November 18, 2024 12:39
@stefanceriu stefanceriu merged commit dc05637 into develop Nov 18, 2024
9 checks passed
@stefanceriu stefanceriu deleted the stefan/localEchoImageAnimation branch November 18, 2024 12:50
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (bef1eda) to head (e4d5584).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...View/TimelineItemViews/VideoRoomTimelineView.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3525      +/-   ##
===========================================
- Coverage    78.72%   78.69%   -0.04%     
===========================================
  Files          752      752              
  Lines        62871    62880       +9     
===========================================
- Hits         49498    49481      -17     
- Misses       13373    13399      +26     
Flag Coverage Δ
unittests 69.59% <95.45%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants