Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compound #3519

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Update compound #3519

merged 2 commits into from
Nov 15, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 15, 2024

This change updates the tokens which removed the textPlaceholder colour in favour of textSecondary.

Additionally it includes support for underlining the plain button styles when Button Shapes are enabled (matching the system behaviour in e.g. the navigation bar).

textPlaceholder is now textSecondary.
@pixlwave pixlwave requested a review from a team as a code owner November 15, 2024 12:35
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 15, 2024 12:35
@pixlwave pixlwave added the pr-misc for other changes label Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 72375cd

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (7e192b7) to head (72375cd).
Report is 4 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3519      +/-   ##
===========================================
- Coverage    78.54%   78.41%   -0.13%     
===========================================
  Files          751      752       +1     
  Lines        62725    62950     +225     
===========================================
+ Hits         49270    49365      +95     
- Misses       13455    13585     +130     
Flag Coverage Δ
unittests 69.55% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit c888a5b into develop Nov 15, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/compound branch November 15, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants