Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knocking Request Cell #3516

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Knocking Request Cell #3516

merged 2 commits into from
Nov 15, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 14, 2024

Check the files in the PR for the preview tests

@Velin92 Velin92 requested a review from a team as a code owner November 14, 2024 16:17
@Velin92 Velin92 requested review from stefanceriu and removed request for a team November 14, 2024 16:17
Copy link

github-actions bot commented Nov 14, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 39ead5f

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
858 1 857 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_emojiPickerScreen()

Flake rate in main: 19.23% (Passed 42 times, Failed 10 times)

Stack Traces | 2.27s run time
failed - Snapshot "Screen" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_emojiPickerScreen-iPhone-16-pseudo.Screen.png"
@+
"file:.../tmp/PreviewTests/test_emojiPickerScreen-iPhone-16-pseudo.Screen.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.87854004 is less than required 1.0
The lowest perceptual color precision 0.0 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, otherwise lgtm 👍

@Velin92 Velin92 force-pushed the mauromito/knock_requests_list branch from c51a5f2 to 39ead5f Compare November 15, 2024 12:42
@Velin92 Velin92 merged commit e17a4d5 into develop Nov 15, 2024
4 checks passed
@Velin92 Velin92 deleted the mauromito/knock_requests_list branch November 15, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants