Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI test fixes #3515

Merged
merged 3 commits into from
Nov 14, 2024
Merged

UI test fixes #3515

merged 3 commits into from
Nov 14, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from pixlwave November 14, 2024 14:23
@stefanceriu stefanceriu requested a review from a team as a code owner November 14, 2024 14:23
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
908 1 907 0
View the top 1 failed tests by shortest run time 
RoomFlowCoordinatorTests testShareRoute()
Stack Traces | 1.29s run time 
XCTAssertTrue failed (.../UnitTests/Sources/RoomFlowCoordinatorTests.swift:233)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 1171aef

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pixlwave
pixlwave approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at all the new snapshots, but we needed to regenerate a bunch anyway as our thresholds are lower on UI tests so sounds good to me!

@stefanceriu stefanceriu added the pr-misc for other changes label Nov 14, 2024
@stefanceriu stefanceriu merged commit 5aadf4e into develop Nov 14, 2024
13 of 14 checks passed
@stefanceriu stefanceriu deleted the stefan/moreUIFixes branch November 14, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave