Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rooms that user has knocked not displaying the request sent screen #3513

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 13, 2024

No description provided.

@Velin92 Velin92 added the pr-bugfix for bug fix label Nov 13, 2024
@Velin92 Velin92 requested a review from a team as a code owner November 13, 2024 17:16
@Velin92 Velin92 requested review from stefanceriu and pixlwave and removed request for a team November 13, 2024 17:16
Copy link

github-actions bot commented Nov 13, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 6d81d4c

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (9746da7) to head (6d81d4c).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...reens/JoinRoomScreen/JoinRoomScreenViewModel.swift 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3513   +/-   ##
========================================
  Coverage    78.53%   78.54%           
========================================
  Files          752      752           
  Lines        62733    62733           
========================================
+ Hits         49269    49275    +6     
+ Misses       13464    13458    -6     
Flag Coverage Δ
unittests 69.48% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ElementX/Sources/Services/Room/KnockedRoomProxy.swift Outdated Show resolved Hide resolved
@Velin92 Velin92 force-pushed the mauroromito/fix_knocked_state branch from 46fc89f to 6d81d4c Compare November 14, 2024 12:43
@Velin92 Velin92 merged commit 2cb7fac into develop Nov 14, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_knocked_state branch November 14, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants