Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the RustSDK to v1.0.67 #3512

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Bump the RustSDK to v1.0.67 #3512

merged 2 commits into from
Nov 13, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from pixlwave November 13, 2024 16:16
@stefanceriu stefanceriu requested a review from a team as a code owner November 13, 2024 16:16
@stefanceriu stefanceriu added the pr-misc for other changes label Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b18d66f

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 20.83333% with 57 lines in your changes missing coverage. Please review.

Project coverage is 78.43%. Comparing base (b122b02) to head (b18d66f).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...om/RoomSummary/RoomMessageEventStringBuilder.swift 0.00% 17 Missing ⚠️
...ne/TimelineController/RoomTimelineController.swift 0.00% 14 Missing ⚠️
...X/Sources/Screens/Timeline/TimelineViewModel.swift 0.00% 8 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 16.66% 5 Missing ⚠️
...meline/TimelineItems/RoomTimelineItemFactory.swift 20.00% 4 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 3 Missing ⚠️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 0.00% 2 Missing ⚠️
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 50.00% 2 Missing ⚠️
...olveVerifiedUserSendFailureScreenCoordinator.swift 0.00% 1 Missing ⚠️
...esolveVerifiedUserSendFailureScreenViewModel.swift 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3512      +/-   ##
===========================================
- Coverage    78.45%   78.43%   -0.02%     
===========================================
  Files          751      752       +1     
  Lines        62584    62735     +151     
===========================================
+ Hits         49099    49205     +106     
- Misses       13485    13530      +45     
Flag Coverage Δ
unittests 69.52% <20.83%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun update 🫠

hasher.combine(timelineID)
}

static var randomSendHandle: SendHandleProxy {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think I prefer call these mock so it is super clear what it is.

Suggested change
static var randomSendHandle: SendHandleProxy {
static var mock: SendHandleProxy {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, totally missed these when adopting captions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be committed.

case sdkError(Swift.Error)
}

let timelineID: TimelineItemIdentifier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency I think we should call this itemID tbf.

@pixlwave pixlwave merged commit 79473ef into develop Nov 13, 2024
11 checks passed
@pixlwave pixlwave deleted the stefan/sdkBump branch November 13, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants