Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1947 - Check expected files are still present before restoring a session. #3507

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner November 12, 2024 12:14
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team November 12, 2024 12:14
Copy link

github-actions bot commented Nov 12, 2024

Fails
🚫 Please provide a complete title that can be used as a changelog entry.
Warnings
⚠️ Please provide a description for this PR.

Generated by 🚫 Danger Swift against 6683879

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (77ade52) to head (6683879).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ources/Services/UserSession/UserSessionStore.swift 0.00% 5 Missing ⚠️
...rces/Services/UserSession/SessionDirectories.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3507      +/-   ##
===========================================
- Coverage    78.73%   78.70%   -0.04%     
===========================================
  Files          743      743              
  Lines        61905    61913       +8     
===========================================
- Hits         48743    48730      -13     
- Misses       13162    13183      +21     
Flag Coverage Δ
unittests 69.46% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 3a600a9 into develop Nov 12, 2024
12 of 13 checks passed
@stefanceriu stefanceriu deleted the stefan/1947 branch November 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants