Make stopSync more aware of background usage. #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
commented
Nov 11, 2024
| @@ -930,7 +934,7 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationFlowCoordinatorDeleg | |||
| backgroundTask = appMediator.beginBackgroundTask { [weak self] in | |||
| guard let self else { return } | |||
|
|
|||
| stopSync() | |||
| stopSync(isBackgroundTask: true) | |||
There was a problem hiding this comment.
I don't think this one is strictly needed, but doesn't hurt.
Generated by 🚫 Danger Swift against 42da81c |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3501 +/- ##
===========================================
- Coverage 78.71% 78.71% -0.01%
===========================================
Files 743 743
Lines 61906 61907 +1
===========================================
Hits 48729 48729
- Misses 13177 13178 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still had a bug where a successful background task was being run in the foreground. So this PR makes
stopSynca bit more aware about whether it's being called from a backround task or not.(#3478)