Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for creating a knocking room #3499

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 8, 2024

the join rule override was not used correctly

@Velin92 Velin92 requested a review from a team as a code owner November 8, 2024 16:22
@Velin92 Velin92 requested review from pixlwave and removed request for a team November 8, 2024 16:22
@Velin92 Velin92 enabled auto-merge (squash) November 8, 2024 16:23
Copy link

github-actions bot commented Nov 8, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against e17bc87

Copy link

sonarqubecloud bot commented Nov 8, 2024

@Velin92 Velin92 added the pr-bugfix for bug fix label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (e7d4ea0) to head (e17bc87).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3499      +/-   ##
===========================================
+ Coverage    78.72%   78.75%   +0.02%     
===========================================
  Files          743      743              
  Lines        61906    61906              
===========================================
+ Hits         48735    48752      +17     
+ Misses       13171    13154      -17     
Flag Coverage Δ
unittests 69.53% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit c9aeebc into develop Nov 8, 2024
13 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_for_creating_a_knock_room branch November 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants