Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop setting up CallKit sessions when joining calls #3496

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

stefanceriu
Copy link
Member

- comes following the discussions on https://developer.apple.com/forums//thread/767949?answerId=812951022#812951022
- this removes the lock screen controls entirely and lets the rest of the app behave normally
@stefanceriu stefanceriu requested a review from a team as a code owner November 7, 2024 14:58
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team November 7, 2024 14:58
@stefanceriu stefanceriu changed the title #3372 - Stop setting up CallKit sessions when joining calls Stop setting up CallKit sessions when joining calls Nov 7, 2024
@stefanceriu stefanceriu added the pr-bugfix for bug fix label Nov 7, 2024
Copy link

sonarqubecloud bot commented Nov 7, 2024

Copy link

codecov bot commented Nov 7, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
848 1 847 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 18.79% (Passed 696 times, Failed 161 times)

Stack Traces | 25.5s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.83825684 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Noting here that we discussed offline about not needing CXEndCallAction and CXSetMutedCallAction but want to do that in a follow-up with more testing.

@stefanceriu stefanceriu merged commit c42ef40 into develop Nov 8, 2024
9 checks passed
@stefanceriu stefanceriu deleted the stefan/callKitTweaks branch November 8, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants