Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the session verification icons and copy. #3495

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Nov 7, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner November 7, 2024 14:21
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team November 7, 2024 14:21
Copy link

github-actions bot commented Nov 7, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 83f8a83

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (c9aeebc) to head (83f8a83).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...cationScreen/SessionVerificationScreenModels.swift 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3495      +/-   ##
===========================================
+ Coverage    78.71%   78.76%   +0.05%     
===========================================
  Files          743      743              
  Lines        61906    61901       -5     
===========================================
+ Hits         48729    48758      +29     
+ Misses       13177    13143      -34     
Flag Coverage Δ
unittests 69.57% <95.45%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu force-pushed the stefan/sessionVerificationTweaks branch from 2f98847 to 83f8a83 Compare November 11, 2024 09:45
Copy link

@stefanceriu stefanceriu merged commit b9409e5 into develop Nov 11, 2024
11 checks passed
@stefanceriu stefanceriu deleted the stefan/sessionVerificationTweaks branch November 11, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants