Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK 1.0.65 #3494

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Update SDK 1.0.65 #3494

merged 2 commits into from
Nov 7, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 7, 2024

Fixes the OOM issue.

@Velin92 Velin92 requested a review from a team as a code owner November 7, 2024 14:08
@Velin92 Velin92 requested review from stefanceriu and removed request for a team November 7, 2024 14:08
@Velin92 Velin92 added the pr-bugfix for bug fix label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against b55f3e7

@Velin92 Velin92 enabled auto-merge (squash) November 7, 2024 14:13
Copy link

sonarqubecloud bot commented Nov 7, 2024

@Velin92 Velin92 merged commit a5cef53 into develop Nov 7, 2024
7 checks passed
@Velin92 Velin92 deleted the mauroromito/update_sdk_v1.0.65 branch November 7, 2024 14:40
Copy link

codecov bot commented Nov 7, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
848 3 845 0
View the top 2 failed tests by shortest run time
UserIndicatorControllerTests testMinimumDisplayDuration()
Stack Traces | 2.8s run time
XCTAssertEqual failed: ("3") is not equal to ("2") (.../UnitTests/Sources/UserIndicatorControllerTests.swift:84)
NotificationSettingsEditScreenViewModelTests testSetModeFailure()
Stack Traces | 57.7s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 18.74% (Passed 694 times, Failed 160 times)

Stack Traces | 3.31s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.848999 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants