-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing fixes #3488
Syncing fixes #3488
Conversation
Generated by 🚫 Danger Swift against 4439172 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
Quality Gate passedIssues Measures |
@@ -150,6 +148,8 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationFlowCoordinatorDeleg | |||
switch action { | |||
case .startCall(let roomID): | |||
self?.handleAppRoute(.call(roomID: roomID)) | |||
case .receivedIncomingCallRequest: | |||
self?.scheduleDelayedSyncStop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just discussed that we need to double-check the impact of this if the app is in the foreground.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked, seems fine
Background Task 23 ("Called by ElementX.debug.dylib, from $s8ElementX14AppCoordinatorC23scheduleDelayedSyncStop33_E85D5AAE1EFD17BA4327A2E0B56B370DLLyyF"), was created over 30 seconds ago. In applications running in the background, this creates a risk of termination. Remember to call UIApplication.endBackgroundTask(_:) for your task in a timely manner to avoid this.
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
(#3478)