Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing fixes #3488

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Syncing fixes #3488

merged 2 commits into from
Nov 6, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Nov 6, 2024

  • prevent background app refresh task expirations from stopping the main app's sync
  • start a background task when receiving calls to receive state updates for longer

(#3478)

@stefanceriu stefanceriu requested a review from pixlwave November 6, 2024 11:04
@stefanceriu stefanceriu requested a review from a team as a code owner November 6, 2024 11:04
Copy link

github-actions bot commented Nov 6, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 4439172

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

Copy link

sonarqubecloud bot commented Nov 6, 2024

@@ -150,6 +148,8 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationFlowCoordinatorDeleg
switch action {
case .startCall(let roomID):
self?.handleAppRoute(.call(roomID: roomID))
case .receivedIncomingCallRequest:
self?.scheduleDelayedSyncStop()
Copy link
Member

@pixlwave pixlwave Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just discussed that we need to double-check the impact of this if the app is in the foreground.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked, seems fine

Background Task 23 ("Called by ElementX.debug.dylib, from $s8ElementX14AppCoordinatorC23scheduleDelayedSyncStop33_E85D5AAE1EFD17BA4327A2E0B56B370DLLyyF"), was created over 30 seconds ago. In applications running in the background, this creates a risk of termination. Remember to call UIApplication.endBackgroundTask(_:) for your task in a timely manner to avoid this.

Copy link

codecov bot commented Nov 6, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
848 2 846 0
View the top 2 failed tests by shortest run time
RoomDetailsEditScreenViewModelTests testErrorShownOnFailedFetchOfMedia()
Stack Traces | 2.65s run time
XCTAssertNotNil failed (.../UnitTests/Sources/RoomDetailsEditScreenViewModelTests.swift:98)
PreviewTests test_roomDirectorySearchScreen()
Stack Traces | 3.53s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomDirectorySearchScreen-iPhone-16-en-GB.1.png"
@+
"file:.../tmp/PreviewTests/test_roomDirectorySearchScreen-iPhone-16-en-GB.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.998765 is less than required 1.0
The lowest perceptual color precision 0.70734376 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@stefanceriu stefanceriu merged commit 10966ab into develop Nov 6, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/syncingFixes branch November 6, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants