Fix a couple of race conditions when observing room info updates for calls.

[pixlwave]

This PR is the iOS part for element-hq/element-meta#2599. There were 2 issues at play:

• A race condition between getting the value of hasRoomCall and it being used in the publisher which could result in a room info update being dropped when it shouldn't be.
• An incoming call would launch the app if it had been killed and attempt to observe the room info update before a user session had been restored.

These issues also affected the ringing not being stopped when the caller hung up as well as the issue mentioned in the story (although honestly, the grace period for ringing is short enough that until I added logs I was often unsure if I had hit a timeout or the app was doing its thing correctly).

Note: I think there are still a couple of smaller issues with call ringing (possibly just matrix.org being slow as sometimes e.g. Call notification is too old would happen) and I wouldn't see CallKit appear at all or it would cancel almost immediately.

Screen.Recording.2024-11-05.at.1.29.11.pm.mov

[stefanceriu]

👏👏👏

[github-actions]

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 6dac0a2

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
848	2	846	0

View the full list of 2 ❄️ flaky tests

PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 18.75% (Passed 650 times, Failed 150 times)

Stack Traces | 9.28s run time

failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.83825684 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 24.42% (Passed 164 times, Failed 53 times)

Stack Traces | 19.2s run time

Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard