Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition when setting up session verification controller subscriptions #3486

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

stefanceriu
Copy link
Member

We were running the SessionVerificationController in a task after updating the session verification state, which would result in trying to subscribe to a nil object.

@stefanceriu stefanceriu requested a review from pixlwave November 5, 2024 16:08
@stefanceriu stefanceriu requested a review from a team as a code owner November 5, 2024 16:08
@stefanceriu stefanceriu added the pr-bugfix for bug fix label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 773f985

Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@stefanceriu stefanceriu enabled auto-merge (rebase) November 5, 2024 16:35
@stefanceriu stefanceriu merged commit c54e4bf into develop Nov 5, 2024
9 checks passed
@stefanceriu stefanceriu deleted the stefan/sessionVerificationRaceCondition branch November 5, 2024 16:50
Copy link

codecov bot commented Nov 5, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
848 1 847 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_userProfileScreen()

Flake rate in main: 20.00% (Passed 32 times, Failed 8 times)

Stack Traces | 8.45s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9031372 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants