Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verify identity button title. #3466

Merged
merged 2 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@
"common_verification_failed" = "Verification failed";
"common_verified" = "Verified";
"common_verify_device" = "Verify device";
"common_verify_identity" = "Verify identity";
"common_video" = "Video";
"common_voice_message" = "Voice message";
"common_waiting" = "Waiting…";
Expand Down
2 changes: 2 additions & 0 deletions ElementX/Sources/Generated/Strings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,8 @@ internal enum L10n {
internal static var commonVerified: String { return L10n.tr("Localizable", "common_verified") }
/// Verify device
internal static var commonVerifyDevice: String { return L10n.tr("Localizable", "common_verify_device") }
/// Verify identity
internal static var commonVerifyIdentity: String { return L10n.tr("Localizable", "common_verify_identity") }
/// Video
internal static var commonVideo: String { return L10n.tr("Localizable", "common_video") }
/// Voice message
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ struct RoomMemberDetailsScreenViewState: BindableState {
var showVerificationSection: Bool {
isVerified == false && !isOwnMemberDetails
}

var verifyButtonTitle: String {
L10n.screenRoomMemberDetailsVerifyButtonTitle(memberDetails?.name ?? "")
}
}

struct RoomMemberDetailsScreenViewStateBindings {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ struct RoomMemberDetailsScreen: View {
var verificationSection: some View {
if context.viewState.showVerificationSection {
Section {
ListRow(label: .default(title: context.viewState.verifyButtonTitle,
ListRow(label: .default(title: L10n.commonVerifyIdentity,
description: L10n.screenRoomMemberDetailsVerifyButtonSubtitle,
icon: \.lock),
kind: .button { })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ struct UserProfileScreenViewState: BindableState {
var showVerificationSection: Bool {
isVerified == false && !isOwnUser
}

var verifyButtonTitle: String {
L10n.screenRoomMemberDetailsVerifyButtonTitle(userProfile?.displayName ?? "")
}
}

struct UserProfileScreenViewStateBindings {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ struct UserProfileScreen: View {
var verificationSection: some View {
if context.viewState.showVerificationSection {
Section {
ListRow(label: .default(title: context.viewState.verifyButtonTitle,
ListRow(label: .default(title: L10n.commonVerifyIdentity,
description: L10n.screenRoomMemberDetailsVerifyButtonSubtitle,
icon: \.lock),
kind: .button { })
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading