Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the flow for disabling key storage. #3464

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 29, 2024

Nothing major here as the strings were already updated, this PR does the following:

  • Refactor RoundedListItem into VisualListItem from Compound and tweak the padding slightly.
  • Update the SecureBackupKeyBackupScreen to match the Figma.

@pixlwave pixlwave requested a review from a team as a code owner October 29, 2024 16:31
@pixlwave pixlwave requested review from Velin92 and stefanceriu and removed request for a team and Velin92 October 29, 2024 16:31
Copy link

github-actions bot commented Oct 29, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b1f3993

Copy link

codecov bot commented Oct 29, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
848 1 847 0
View the top 1 failed tests by shortest run time
PreviewTests test_userProfileScreen()
Stack Traces | 2.71s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-pseudo.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-pseudo.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.892395 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave force-pushed the doug/disable-key-storage branch from b27ea15 to b1f3993 Compare October 29, 2024 16:52
Copy link

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 29, 2024
@pixlwave pixlwave merged commit 368226f into develop Oct 29, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/disable-key-storage branch October 29, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants