Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the flow for setting up a recovery key. #3463

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

pixlwave
Copy link
Member

This PR closes #3446 by showing the recovery key banner when setup is required, along with updating a few strings and icons in the flow. Nothing major although some of the strings are included in #3428, so there may be snapshot conflicts once that is merged.

@pixlwave pixlwave requested a review from a team as a code owner October 29, 2024 12:05
@pixlwave pixlwave requested review from Velin92 and stefanceriu and removed request for a team and Velin92 October 29, 2024 12:05
@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7b72be9

Copy link

codecov bot commented Oct 29, 2024

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
848 4 844 0
View the top 2 failed tests by shortest run time
PreviewTests test_emojiPickerScreen()
Stack Traces | 4.68s run time
failed - Snapshot "Screen" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_emojiPickerScreen-iPhone-16-en-GB.Screen.png"
@+
"file:.../tmp/PreviewTests/test_emojiPickerScreen-iPhone-16-en-GB.Screen.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8803711 is less than required 1.0
The lowest perceptual color precision 0.0 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_userProfileScreen()
Stack Traces | 9.73s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9031372 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
View the full list of 1 ❄️ flaky tests
PreviewTests test_joinRoomScreen()

Flake rate in main: 15.86% (Passed 122 times, Failed 23 times)

Stack Traces | 4.64s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-pseudo.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-pseudo.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.95932007 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me 👍

@pixlwave pixlwave force-pushed the doug/setup-recovery-tweaks branch from d38a039 to 1e851f3 Compare October 29, 2024 13:55
Copy link

@pixlwave pixlwave merged commit c11e49f into develop Oct 29, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/setup-recovery-tweaks branch October 29, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Redesign Encryption Settings: Setting up recovery
2 participants