Hook reaction pickers into the system's recently used keyboard emojis

[stefanceriu]

The way this works is by opening the com.apple.EmojiPreferences suite and then getting the EMFDefaults.EMFRecentsKey from it. The same goes in opposite direction when chosing a reaction from the app.

NB

• the feature is currently only enabled on development builds
• there will be no changes on the mac until we figure out what to do with the context menu

[github-actions]

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4f0c88b

[pixlwave]

👏

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
5.3% Duplication on New Code

See analysis details on SonarCloud

[codecov]

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
849	3	846	0

View the top 3 failed tests by shortest run time

PreviewTests test_secureBackupRecoveryKeyScreen()

Stack Traces | 2.17s run time

failed - Snapshot "Not set up" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_secureBackupRecoveryKeyScreen-iPhone-16-en-GB.Not-set-up.png"
@+
"file:.../tmp/PreviewTests/test_secureBackupRecoveryKeyScreen-iPhone-16-en-GB.Not-set-up.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9957123 is less than required 1.0
The lowest perceptual color precision 0.70734376 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

PreviewTests test_createRoom()

Stack Traces | 3.07s run time

failed - Snapshot "Create Room" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_createRoom-iPhone-16-en-GB.Create-Room.png"
@+
"file:.../tmp/PreviewTests/test_createRoom-iPhone-16-en-GB.Create-Room.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.957489 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

PreviewTests test_secureBackupScreen()

Stack Traces | 7.51s run time

failed - Snapshot "Both setup" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_secureBackupScreen-iPhone-16-en-GB.Both-setup.png"
@+
"file:.../tmp/PreviewTests/test_secureBackupScreen-iPhone-16-en-GB.Both-setup.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.92419434 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

[frebib]

Does this mean the information won't be sync'ed with Element Web's own tracking of frecently used emojis in account data?

[Hywan]

That's neat!

[Hywan]

@frebib indeed, this information is not synced, it's only device-specific.

[simonmichael]

If this is what I think it is, thank you very much! Emoji favourites save much time.

With today's 1.9.4 testflight EXI build I see two emoji pickers.

1. when I focus the message text field and press the keyboard's emoji button:

2. when I long press on a message:

And when I press on the more icon here I get

3. a full-screen vertical scroll picker:

I can't quite remember what it showed before this release - something less native-looking that didn't know my favourites (perhaps it was 3). 1 is much more usable. Hopefully favourites will be coming to the reacting-to-message case as well in due course!

(iphone SE 2nd generation, IOS 18.0.1)

[simonmichael]

Update for other users/testers after some advice from chat.

This is disabled by default. To test it, you need to enable the secret developer options screen in app settings, then enable the Timeline -> Show frequently used emojis toggle:

After doing this, reacting to a message (my image 2 above) shows your recent reactions instead of generic ones , and the full browser (my image 3) now has a Frequently used section at the top (like the images at top of this issue page).