generated from element-hq/.github
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace individual RoomProxy properties with a stored RoomInfo. #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against bfdb4ff |
❌ 3 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
pixlwave
changed the title
Replace individual RoomProxy properties with a store RoomInfo.
Replace individual RoomProxy properties with a stored RoomInfo.
Oct 24, 2024
pixlwave
force-pushed
the
doug/room-info-publisher
branch
from
October 25, 2024 09:19
9897171
to
4841135
Compare
SonarCloud is grumbling about mocks, doesn't seem worth worrying about. |
pixlwave
force-pushed
the
doug/room-info-publisher
branch
from
October 25, 2024 10:51
4841135
to
1b97d56
Compare
stefanceriu
approved these changes
Oct 25, 2024
ElementX/Sources/Screens/RoomChangeRolesScreen/RoomChangeRolesScreenViewModel.swift
Show resolved
Hide resolved
...X/Sources/Screens/RoomRolesAndPermissionsScreen/RoomRolesAndPermissionsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
pixlwave
force-pushed
the
doug/room-info-publisher
branch
from
October 28, 2024 11:37
1b97d56
to
bfdb4ff
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit replaces the actions publisher with an info publisher on the JoinedRoomProxy and stores the info locally.
The second commit removes all the properties that can be read from the room info and adds an
info
property to theInvited
/KnockedRoomProxy
s.Not handled in this PR:
RoomDetails
is still a thing, it seemed to add too much to this PR.RoomSummaryDetails
could also lean on the newRoomInfoProxy
a load more too now.