Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace individual RoomProxy properties with a stored RoomInfo. #3445

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 24, 2024

The first commit replaces the actions publisher with an info publisher on the JoinedRoomProxy and stores the info locally.

The second commit removes all the properties that can be read from the room info and adds an info property to the Invited/KnockedRoomProxys.

Not handled in this PR:

  • Plenty of uses of the room info publisher could now subscribe to it instead of reading once.
  • RoomDetails is still a thing, it seemed to add too much to this PR.
  • RoomSummaryDetails could also lean on the new RoomInfoProxy a load more too now.

@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 24, 2024
@pixlwave pixlwave requested a review from a team as a code owner October 24, 2024 12:07
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 24, 2024 12:07
Copy link

github-actions bot commented Oct 24, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against bfdb4ff

Copy link

codecov bot commented Oct 24, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
849 3 846 0
View the top 3 failed tests by shortest run time
PreviewTests test_secureBackupRecoveryKeyScreen()
Stack Traces | 1.5s run time
failed - Snapshot "Not set up" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_secureBackupRecoveryKeyScreen-iPhone-16-en-GB.Not-set-up.png"
@+
"file:.../tmp/PreviewTests/test_secureBackupRecoveryKeyScreen-iPhone-16-en-GB.Not-set-up.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9957123 is less than required 1.0
The lowest perceptual color precision 0.70734376 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_createRoom()
Stack Traces | 2.35s run time
failed - Snapshot "Create Room" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_createRoom-iPhone-16-en-GB.Create-Room.png"
@+
"file:.../tmp/PreviewTests/test_createRoom-iPhone-16-en-GB.Create-Room.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.957489 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_secureBackupScreen()
Stack Traces | 22.8s run time
failed - Snapshot "Both setup" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_secureBackupScreen-iPhone-16-en-GB.Both-setup.png"
@+
"file:.../tmp/PreviewTests/test_secureBackupScreen-iPhone-16-en-GB.Both-setup.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.92419434 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave changed the title Replace individual RoomProxy properties with a store RoomInfo. Replace individual RoomProxy properties with a stored RoomInfo. Oct 24, 2024
@pixlwave pixlwave force-pushed the doug/room-info-publisher branch from 9897171 to 4841135 Compare October 25, 2024 09:19
@pixlwave
Copy link
Member Author

SonarCloud is grumbling about mocks, doesn't seem worth worrying about.

@pixlwave pixlwave force-pushed the doug/room-info-publisher branch from 4841135 to 1b97d56 Compare October 25, 2024 10:51
@pixlwave pixlwave force-pushed the doug/room-info-publisher branch from 1b97d56 to bfdb4ff Compare October 28, 2024 11:37
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.5% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@pixlwave pixlwave merged commit 7c75498 into develop Oct 28, 2024
5 of 7 checks passed
@pixlwave pixlwave deleted the doug/room-info-publisher branch October 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants