Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove iOS 16 support #3443

Merged
merged 8 commits into from
Oct 24, 2024
Merged

remove iOS 16 support #3443

merged 8 commits into from
Oct 24, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 24, 2024

remove support for iOS and updated some functions that were deprecated

@Velin92 Velin92 requested a review from a team as a code owner October 24, 2024 10:38
@Velin92 Velin92 requested review from pixlwave and removed request for a team October 24, 2024 10:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 2b3f204

@Velin92 Velin92 added the pr-misc for other changes label Oct 24, 2024
@Velin92 Velin92 force-pushed the mauroromito/drop_ios_16 branch from a1b09eb to c903631 Compare October 24, 2024 10:50
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
847 2 845 0
View the top 1 failed tests by shortest run time 
PreviewTests test_timelineItemBubbledStylerView()
Stack Traces | 60s run time 
Test exceeded execution time allowance of 1 minute (see `-[XCTestCase executionTimeAllowance]`)
View the full list of 1 ❄️ flaky tests 
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 22.47% (Passed 69 times, Failed 20 times)

Stack Traces | 31s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 merged commit 7d373c0 into develop Oct 24, 2024
6 of 7 checks passed
@Velin92 Velin92 deleted the mauroromito/drop_ios_16 branch October 24, 2024 15:21
@pixlwave pixlwave added pr-build for changes related to build, tools, CI/CD and removed pr-misc for other changes labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave Awaiting requested review from pixlwave pixlwave is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @pixlwave