Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where the room state wouldn't indicate when a call was in progress. #3442

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 24, 2024

Fixes a bug with call state by including matrix-org/matrix-rust-sdk#4166. Additionally updates the analytics events package to handle some new UTD cases.

calls.mov

@pixlwave pixlwave requested a review from a team as a code owner October 24, 2024 09:43
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 24, 2024 09:43
Copy link

github-actions bot commented Oct 24, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 24ae5b8

@pixlwave pixlwave added the pr-bugfix for bug fix label Oct 24, 2024
@pixlwave pixlwave changed the title Update the SDK Fix a bug where the room state wouldn't indicate when a call was in progress. Oct 24, 2024
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, 🚀 it!

Copy link

Copy link

codecov bot commented Oct 24, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
847 1 846 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_emojiPickerScreen()

Flake rate in main: 4.35% (Passed 44 times, Failed 2 times)

Stack Traces | 5.15s run time
failed - Snapshot "Screen" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_emojiPickerScreen-iPhone-16-pseudo.Screen.png"
@+
"file:.../tmp/PreviewTests/test_emojiPickerScreen-iPhone-16-pseudo.Screen.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.87854004 is less than required 1.0
The lowest perceptual color precision 0.0 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants