Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HeroImage to match the BigIcon component from Compound. #3439

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 23, 2024

HeroImage is now completely in line with the Figma (inc renaming to BigIcon). It is still in the EX project for now to be less disruptive as this PR feels far reaching enough already. We can move it across in a following PR.

This is the iOS equivalent to element-hq/element-x-android#3719

We can move it across in a following PR.
@pixlwave pixlwave requested a review from a team as a code owner October 23, 2024 10:33
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 23, 2024 10:33
@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 23, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 44685ea

Copy link

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚀 👏

Copy link

codecov bot commented Oct 23, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
847 2 845 0
View the top 1 failed tests by shortest run time
PreviewTests test_formButtonStyles()
Stack Traces | 60s run time
Test exceeded execution time allowance of 1 minute (see `-[XCTestCase executionTimeAllowance]`)
View the full list of 1 ❄️ flaky tests
PreviewTests test_loginScreen()

Flake rate in main: 27.41% (Passed 286 times, Failed 108 times)

Stack Traces | 4.08s run time
failed - Snapshot "matrix.org" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-pseudo.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-pseudo.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8482666 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave merged commit 6584b4d into develop Oct 23, 2024
8 of 9 checks passed
@pixlwave pixlwave deleted the doug/big-icon branch October 23, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants