-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt various Rust side API changes #3437
Conversation
Generated by 🚫 Danger Swift against 3385aba |
5812c6f
to
7481b32
Compare
❌ 2 Tests Failed:
View the top 1 failed tests by shortest run time
View the full list of 1 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
7481b32
to
3385aba
Compare
Quality Gate passedIssues Measures |
@@ -39,16 +39,7 @@ enum ClientProxyError: Error { | |||
} | |||
|
|||
enum SlidingSyncConstants { | |||
static let defaultTimelineLimit: UInt32 = 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this go, wasn't the idea that one day we would use a higher value here for e.g. iPad so that the screen is filled better like we do on EI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh or was that pagination size, I can't remember now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It moved to the rust side. We agreed that until we make sliding things work properly it's best to keep things in one single place.
No description provided.