Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt various Rust side API changes #3437

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Adopt various Rust side API changes #3437

merged 1 commit into from
Oct 23, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Oct 23, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner October 23, 2024 06:43
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team October 23, 2024 06:43
Copy link

github-actions bot commented Oct 23, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 3385aba

Copy link

codecov bot commented Oct 23, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
847 2 845 0
View the top 1 failed tests by shortest run time
PreviewTests test_advancedSettingsScreen()
Stack Traces | 60s run time
Test exceeded execution time allowance of 1 minute (see `-[XCTestCase executionTimeAllowance]`)
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 18.70% (Passed 426 times, Failed 98 times)

Stack Traces | 2.87s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.83825684 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

@@ -39,16 +39,7 @@ enum ClientProxyError: Error {
}

enum SlidingSyncConstants {
static let defaultTimelineLimit: UInt32 = 20
Copy link
Member

@pixlwave pixlwave Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this go, wasn't the idea that one day we would use a higher value here for e.g. iPad so that the screen is filled better like we do on EI?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh or was that pagination size, I can't remember now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It moved to the rust side. We agreed that until we make sliding things work properly it's best to keep things in one single place.

@stefanceriu stefanceriu merged commit 8f9f8cb into develop Oct 23, 2024
6 of 7 checks passed
@stefanceriu stefanceriu deleted the stefan/rust4159 branch October 23, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants