Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rendering media captions in the timeline. #3429

Merged
merged 1 commit into from
Oct 21, 2024

Add support for rendering media captions in the timeline.

9e2586d
Select commit
Loading
Failed to load commit list.
Merged

Add support for rendering media captions in the timeline. #3429

Add support for rendering media captions in the timeline.
9e2586d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 0s

77.78% (+0.02%) compared to bd4ecdd

View this Pull Request on Codecov

77.78% (+0.02%) compared to bd4ecdd

Details

Codecov Report

Attention: Patch coverage is 88.42105% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.78%. Comparing base (bd4ecdd) to head (9e2586d).

Files with missing lines Patch % Lines
...View/TimelineItemViews/ImageRoomTimelineView.swift 88.09% 5 Missing ⚠️
...View/TimelineItemViews/VideoRoomTimelineView.swift 91.17% 3 Missing ⚠️
...eItems/EventBasedMessageTimelineItemProtocol.swift 78.57% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3429      +/-   ##
===========================================
+ Coverage    77.76%   77.78%   +0.02%     
===========================================
  Files          738      739       +1     
  Lines        60626    60701      +75     
===========================================
+ Hits         47144    47218      +74     
- Misses       13482    13483       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov