Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only subscribe to identity updates if the room is encrypted. #3414

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

pixlwave
Copy link
Member

Fixes #3409.

Copy link

github-actions bot commented Oct 15, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 3aed992

Copy link

@pixlwave pixlwave added the pr-bugfix for bug fix label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.72%. Comparing base (236d142) to head (3aed992).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3414   +/-   ##
========================================
  Coverage    77.72%   77.72%           
========================================
  Files          739      739           
  Lines        60207    60207           
========================================
  Hits         46798    46798           
  Misses       13409    13409           
Flag Coverage Δ
unittests 69.12% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 3d797cc into develop Oct 16, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/encrypted-room-identity-updates branch October 16, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Invisible Crypto: User Identity notice are displayed in clear room
2 participants