Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow video uploads to be optimised to reduce bandwidth. #3408

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 14, 2024

This PR is the first part of #3398 and makes the following changes:

  • Add a toggle (in Developer Options for now) to reduce the quality of media uploads
  • Use this toggle to change the video quality preset from 1080p to 480p (which is 360p when video are 16:9).

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Oct 14, 2024
@pixlwave pixlwave requested a review from a team as a code owner October 14, 2024 11:52
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 14, 2024 11:52
@pixlwave pixlwave force-pushed the doug/media-quality-setting branch from e0ad7a2 to 0a2f16e Compare October 14, 2024 11:55
@pixlwave pixlwave requested a review from Velin92 October 14, 2024 11:55
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0a2f16e

Copy link

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 72.61905% with 23 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (a16e134) to head (0a2f16e).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ests/Sources/MediaUploadingPreprocessorTests.swift 86.88% 8 Missing ⚠️
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 6 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 0.00% 2 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 2 Missing ⚠️
...ces/FlowCoordinators/SettingsFlowCoordinator.swift 0.00% 1 Missing ⚠️
...sEditScreen/RoomDetailsEditScreenCoordinator.swift 0.00% 1 Missing ⚠️
...sEditScreen/UserDetailsEditScreenCoordinator.swift 0.00% 1 Missing ⚠️
...ilsEditScreen/UserDetailsEditScreenViewModel.swift 50.00% 1 Missing ⚠️
...s/StartChatScreen/StartChatScreenCoordinator.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3408   +/-   ##
========================================
  Coverage    77.71%   77.72%           
========================================
  Files          739      739           
  Lines        60149    60203   +54     
========================================
+ Hits         46747    46790   +43     
- Misses       13402    13413   +11     
Flag Coverage Δ
unittests 69.08% <72.61%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

case publicSearchEnabled
case fuzzyRoomListSearchEnabled
case pinningEnabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

@pixlwave pixlwave merged commit 98a5ee5 into develop Oct 14, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/media-quality-setting branch October 14, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants