Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Room with knock rule #3397

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Create Room with knock rule #3397

merged 3 commits into from
Oct 14, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 10, 2024

This does not include the SDK implementation yet, so it won't affect anything and the room will be created as a normal public room for now.

@Velin92 Velin92 requested a review from a team as a code owner October 10, 2024 15:48
@Velin92 Velin92 requested review from pixlwave and removed request for a team October 10, 2024 15:48
pixlwave
pixlwave approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✊✊✊

ElementX/Sources/Application/AppSettings.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/CreateRoom/CreateRoomModels.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/CreateRoom/CreateRoomViewModel.swift Show resolved Hide resolved
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift Show resolved Hide resolved
ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/View/DeveloperOptionsScreen.swift Outdated Show resolved Hide resolved
UnitTests/Sources/CreateRoomViewModelTests.swift Outdated Show resolved Hide resolved
@Velin92 Velin92 force-pushed the mauroromito/knocking_create_room branch from 53ccc01 to 758a1a7 Compare October 10, 2024 16:48
@Velin92 Velin92 enabled auto-merge (squash) October 10, 2024 16:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 8af63b7

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
842 1 841 0
View the top 1 failed tests by shortest run time 
RoomFlowCoordinatorTests testRoomPresentation()
Stack Traces | 15s run time 
XCTAssertTrue failed (.../UnitTests/Sources/RoomFlowCoordinatorTests.swift:24)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Oct 14, 2024
@Velin92 Velin92 force-pushed the mauroromito/knocking_create_room branch from 758a1a7 to 8af63b7 Compare October 14, 2024 09:52
@Velin92 Velin92 disabled auto-merge October 14, 2024 09:52
@Velin92 Velin92 merged commit a16e134 into develop Oct 14, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/knocking_create_room branch October 14, 2024 09:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @pixlwave