Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state events for pinning and unpinning #3123

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 6, 2024

fixes #3119

simulator_screenshot_501D9BC8-BBC3-4FBE-BBFD-73052E73EDBB

@Velin92 Velin92 requested a review from a team as a code owner August 6, 2024 14:48
@Velin92 Velin92 requested review from stefanceriu and removed request for a team August 6, 2024 14:48
Copy link

github-actions bot commented Aug 6, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 15a0034

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Aug 6, 2024
@Velin92 Velin92 force-pushed the mauroromito/pin_state_events branch from 6f594aa to 15a0034 Compare August 6, 2024 15:03
@Velin92 Velin92 enabled auto-merge (squash) August 6, 2024 15:05
@Velin92 Velin92 disabled auto-merge August 6, 2024 15:05
@Velin92 Velin92 changed the title State events for pinning/unpinning state events Aug 6, 2024
@Velin92 Velin92 enabled auto-merge (squash) August 6, 2024 15:07
Copy link

sonarqubecloud bot commented Aug 6, 2024

@Velin92 Velin92 disabled auto-merge August 6, 2024 15:16
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.42%. Comparing base (0c9da2c) to head (15a0034).
Report is 2 commits behind head on develop.

Files Patch % Lines
...ne/TimelineItems/RoomStateEventStringBuilder.swift 0.00% 10 Missing ⚠️
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #3123    +/-   ##
=========================================
  Coverage    77.41%   77.42%            
=========================================
  Files          714      715     +1     
  Lines        55355    55613   +258     
=========================================
+ Hits         42855    43060   +205     
- Misses       12500    12553    +53     
Flag Coverage Δ
unittests 68.39% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 changed the title state events state events for pinning and unpinning Aug 6, 2024
@Velin92 Velin92 merged commit a39a8f9 into develop Aug 6, 2024
10 checks passed
@Velin92 Velin92 deleted the mauroromito/pin_state_events branch August 6, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] State events for pinning and unpinning
2 participants