-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Encryption Authenticity explanations. #3116
Conversation
cccd6b8
to
7630c10
Compare
Generated by 🚫 Danger Swift against a96a55d |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3116 +/- ##
===========================================
+ Coverage 77.69% 77.71% +0.02%
===========================================
Files 714 714
Lines 55246 55363 +117
===========================================
+ Hits 42922 43025 +103
- Misses 12324 12338 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7630c10
to
5de4470
Compare
@@ -169,23 +179,54 @@ struct TimelineItemMenu: View { | |||
} | |||
} | |||
|
|||
private extension EncryptionAuthenticity { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of having Colors encoded into the EncryptionAuthenticity. Wouldn't it be better if we would use the Compound approach and replace enum Color { case red, gray }
with an enum Importance { case primary, secondary }
or similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I now understand that this has been done this way to keep in line with the Rust implementation.
For posterity though, we belive colors to be inherently localisable and severity
to be a way better abstraction.
Otherwise we can find ourselves in weird situations in which colors don't mean what we expect them to e.g. In China, red is auspicious—associated with life-generating energy (the sun, blood, and fire)—and is the color of celebrations and prosperity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context this is on purpose, and we want consistency across clients on how crypto shields/warning are represented(idealy same icons, colors, text).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, just pointing out that doesn't seem to be a winning approach seeing as how both icons and colors need to also be localized for the various cultures matrix/element will be used in.
Another random example:
UX designers need to take into account cultural differences when selecting symbols and colors. For example, while the color green is associated with life and growth in many Western cultures, it symbolizes death in some Asian countries
5de4470
to
a96a55d
Compare
Quality Gate passedIssues Measures |
This PR makes the following changes:
Closes #3109
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-01.at.16.42.47.mp4