Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the inviter to JoinRoomScreen when it's an invite. #3093

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

pixlwave
Copy link
Member

This PR extracts the invite label from the home screen invite cells into their own view (with a dedicated model to pre-compute the attributed string) and adds it to the JoinRoomScreen to match Android.

Simulator Screenshot - iPhone 15 Pro - 2024-07-26 at 14 46 20

@pixlwave pixlwave added the pr-change for updates to an existing feature label Jul 26, 2024
@pixlwave pixlwave requested a review from a team as a code owner July 26, 2024 13:48
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 26, 2024 13:48
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b4dae60

Copy link

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (5a4d21a) to head (b4dae60).

Files Patch % Lines
...s/Screens/JoinRoomScreen/View/JoinRoomScreen.swift 50.00% 3 Missing ⚠️
...reens/JoinRoomScreen/JoinRoomScreenViewModel.swift 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3093   +/-   ##
========================================
  Coverage    77.92%   77.93%           
========================================
  Files          703      704    +1     
  Lines        54436    54460   +24     
========================================
+ Hits         42421    42444   +23     
- Misses       12015    12016    +1     
Flag Coverage Δ
unittests 68.54% <94.20%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 0fab3a8 into develop Jul 29, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/join-room-inviter branch July 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants