Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the string used for encrypted events in the room list. #3030

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

pixlwave
Copy link
Member

Fixes #2977 although to be fair, I have a feeling that this was being shown by #2979 and normally wouldn't be visible anyway.

@pixlwave pixlwave requested a review from a team as a code owner July 12, 2024 14:47
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 12, 2024 14:47
@pixlwave pixlwave added the pr-bugfix for bug fix label Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 572e8e9

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.92%. Comparing base (f9d107c) to head (572e8e9).

Files Patch % Lines
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3030      +/-   ##
===========================================
- Coverage    77.92%   77.92%   -0.01%     
===========================================
  Files          695      695              
  Lines        53997    54001       +4     
===========================================
+ Hits         42079    42082       +3     
- Misses       11918    11919       +1     
Flag Coverage Δ
unittests 68.73% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I don't think its actually meant to be shown but this should still be correct if it is.
@pixlwave pixlwave force-pushed the doug/encrypted-last-message branch from aabe358 to 572e8e9 Compare July 15, 2024 13:46
Copy link

@pixlwave pixlwave merged commit 2e6def5 into develop Jul 16, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/encrypted-last-message branch July 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UTD errors are shown incorrectly in room previews.
2 participants