Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the timeline from requesting back pagination whilst loading existing items. #2969

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 26, 2024

This PR makes 3 changes (and is probably easiest to review commit by commit):

  • Detached timelines were erroring due to attempting to subscribe to back pagination status (apparently no longer supported by the SDK).
  • Make sure we await the loading of existing timeline items now that Rust doesn't provide them to us when setting up the subscription - fixes a bug where an error would be shown when navigating to an event permalink.
  • Even once the above was fixed, the TimelineTableViewController could sometimes attempt to back paginate whilst loading the existing items. Now we use an initial pagination state that will prevent this from happening until the items have loaded.

@pixlwave pixlwave added the pr-bugfix for bug fix label Jun 26, 2024
@pixlwave pixlwave requested a review from a team as a code owner June 26, 2024 17:11
@pixlwave pixlwave requested review from Velin92 and removed request for a team June 26, 2024 17:11
Copy link

@pixlwave pixlwave changed the title Stop the timeline from back paginating whilst loading existing items. Stop the timeline from requesting back pagination whilst loading existing items. Jun 26, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 964fec0

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.99%. Comparing base (342cfc0) to head (964fec0).

Files Patch % Lines
...urces/Services/Timeline/RoomTimelineProvider.swift 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2969      +/-   ##
===========================================
- Coverage    78.01%   77.99%   -0.02%     
===========================================
  Files          693      693              
  Lines        54164    54175      +11     
===========================================
- Hits         42254    42253       -1     
- Misses       11910    11922      +12     
Flag Coverage Δ
unittests 68.73% <14.28%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave merged commit d977efd into develop Jun 27, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/initial-timeline-items branch June 27, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants