-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Towncrier with GitHub releases + labels. #2966
The head ref may contain hidden characters: "doug/\u{1F525}towncrier\u{1F525}"
Conversation
Generated by 🚫 Danger Swift against 3c6540e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but what happens if a pr has multiple labels? Would it appear under multiple categories?
Oh yeah, Stefan asked this. Let's try in the test repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
This PR had 3 tags, and the first one (I assume from the release.yml ordering) got chosen. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2966 +/- ##
===========================================
+ Coverage 77.98% 78.05% +0.06%
===========================================
Files 693 693
Lines 54172 54172
===========================================
+ Hits 42248 42283 +35
+ Misses 11924 11889 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Stop requesting a changelog file.
Quality Gate passedIssues Measures |
We weren't using Towncrier very well so this PR replaces it with the use of GitHub's generated release notes along with a configuration that will categorise each entry based upon one of the following labels being applied:
Labels added here: https://github.com/element-hq/element-x-ios/labels?q=pr-
These labels can be added after the PR is merged, so long as they're there before the release is made.
The second commit removes Towncrier. I made a second repo to figure the flow out, but not sure how to validate the changes on EX other than wait for the next release and tidy up anything that comes out of that.