Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

room membership change states will use displayName #2910

Merged
merged 1 commit into from
Jun 11, 2024
Merged

room membership change states will use displayName #2910

merged 1 commit into from
Jun 11, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 11, 2024

fixes #2846

@Velin92 Velin92 requested a review from a team as a code owner June 11, 2024 10:00
@Velin92 Velin92 requested review from stefanceriu and removed request for a team June 11, 2024 10:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 1e8c0cf

@Velin92 Velin92 force-pushed the mauroromito/room_membeship_change_use_display_name branch from b8855f0 to 24f4234 Compare June 11, 2024 10:14
stefanceriu
stefanceriu approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Velin92 Velin92 force-pushed the mauroromito/room_membeship_change_use_display_name branch from 24f4234 to 1e8c0cf Compare June 11, 2024 11:58
@Velin92 Velin92 enabled auto-merge (rebase) June 11, 2024 11:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu disabled auto-merge June 11, 2024 15:09
@stefanceriu stefanceriu merged commit 61e00cf into develop Jun 11, 2024
4 of 5 checks passed
@stefanceriu stefanceriu deleted the mauroromito/room_membeship_change_use_display_name branch June 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"You invited %1$@" still shows a matrix id
2 participants
@Velin92 @stefanceriu