Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK #2857

Merged
merged 6 commits into from
May 20, 2024
Merged

Bump SDK #2857

merged 6 commits into from
May 20, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented May 17, 2024

this requires a new SDK release.

The pagination handling has been changed slightly, this PR was made to check if the changes are valid.

@Velin92 Velin92 requested a review from a team as a code owner May 17, 2024 15:45
@Velin92 Velin92 requested review from stefanceriu and pixlwave and removed request for a team May 17, 2024 15:45
Copy link

github-actions bot commented May 17, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against ed359b4

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.40%. Comparing base (56eb524) to head (cea9840).

Files Patch % Lines
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 0.00% 1 Missing ⚠️
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2857      +/-   ##
===========================================
+ Coverage    74.33%   74.40%   +0.07%     
===========================================
  Files          578      578              
  Lines        40973    40972       -1     
===========================================
+ Hits         30456    30484      +28     
+ Misses       10517    10488      -29     
Flag Coverage Δ
unittests 62.20% <87.50%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you're happy with the commits I pushed on top.

@Velin92 Velin92 merged commit 545b5c3 into develop May 20, 2024
3 checks passed
@Velin92 Velin92 deleted the mauroromito/sdk_bump branch May 20, 2024 12:37
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants