-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SDK #2857
Bump SDK #2857
Conversation
Generated by 🚫 Danger Swift against ed359b4 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2857 +/- ##
===========================================
+ Coverage 74.33% 74.40% +0.07%
===========================================
Files 578 578
Lines 40973 40972 -1
===========================================
+ Hits 30456 30484 +28
+ Misses 10517 10488 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if you're happy with the commits I pushed on top.
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
this requires a new SDK release.
The pagination handling has been changed slightly, this PR was made to check if the changes are valid.