Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final changes for Room Moderation #2576

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Final changes for Room Moderation #2576

merged 5 commits into from
Mar 15, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Mar 14, 2024

  • Add confirmation for the user to save or discard any changes when cancelling the ChangeRoles and ChangePermissions screens.
  • Change Delete messages to Remove messages to align with the timeline action.
  • Fix a bunch of tests (inc refactor of Onboarding to AuthenticationStart)
  • Run periphery for Moderation feature.

Closes #2358
Closes #2356
Closes #2357

@pixlwave pixlwave requested a review from a team as a code owner March 14, 2024 17:16
@pixlwave pixlwave requested review from Velin92 and removed request for a team March 14, 2024 17:16
Copy link

github-actions bot commented Mar 14, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f27b1f7

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 27.77778% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 74.54%. Comparing base (668c518) to head (f27b1f7).

Files Patch % Lines
...sScreen/RoomChangePermissionsScreenViewModel.swift 11.11% 8 Missing ⚠️
...geRolesScreen/RoomChangeRolesScreenViewModel.swift 11.11% 8 Missing ⚠️
...sionsScreen/View/RoomChangePermissionsScreen.swift 44.44% 5 Missing ⚠️
...ChangeRolesScreen/View/RoomChangeRolesScreen.swift 37.50% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2576      +/-   ##
===========================================
- Coverage    74.62%   74.54%   -0.08%     
===========================================
  Files          554      554              
  Lines        38225    38252      +27     
  Branches     17335    17335              
===========================================
- Hits         28524    28514      -10     
- Misses        9701     9738      +37     
Flag Coverage Δ
unittests 60.75% <27.77%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave force-pushed the doug/discard-moderation branch from 51e4673 to f27b1f7 Compare March 15, 2024 07:45
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave merged commit 3ba34c0 into develop Mar 15, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/discard-moderation branch March 15, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Change user rights [Task] Remove a user from a room [Task] Change the role of a user
2 participants