Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy searching debouncing #1506

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Conversation

stefanceriu
Copy link
Member

Added debouncer for fuzzy room list searching

@stefanceriu stefanceriu requested a review from a team as a code owner August 17, 2023 10:52
@stefanceriu stefanceriu requested review from alfogrillo and Velin92 and removed request for a team and alfogrillo August 17, 2023 10:52
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L114 - A doc comment should be attached to a declaration. (orphaned_doc_comment)

Generated by 🚫 Danger Swift against 304eb7b

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 65.51% and project coverage change: +0.01% 🎉

Comparison is base (22e4f21) 53.62% compared to head (304eb7b) 53.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1506      +/-   ##
===========================================
+ Coverage    53.62%   53.63%   +0.01%     
===========================================
  Files          399      399              
  Lines        26551    26556       +5     
  Branches     13257    13248       -9     
===========================================
+ Hits         14237    14243       +6     
+ Misses       11931    11929       -2     
- Partials       383      384       +1     
Flag Coverage Δ
unittests 23.24% <65.51%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Sources/Screens/HomeScreen/HomeScreenModels.swift 81.48% <ø> (ø)
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift 53.43% <0.00%> (+1.27%) ⬆️
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 82.45% <69.09%> (-0.82%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu requested a review from Velin92 August 17, 2023 11:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit a11325b into develop Aug 17, 2023
@stefanceriu stefanceriu deleted the stefan/fuzzySearchingDebouncing branch August 17, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants