Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device verification appears after a fresh new registration #3126

Closed
manuroe opened this issue Aug 7, 2024 · 0 comments
Closed

Device verification appears after a fresh new registration #3126

manuroe opened this issue Aug 7, 2024 · 0 comments
Labels
A-Authentication A-E2EE-Cross-Signing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@manuroe
Copy link
Member

manuroe commented Aug 7, 2024

Steps to reproduce

  1. Select a HS with a MAS accepting registration (ask if you do not know one)
  2. Create an account
The device verification unexpectly appears

Outcome

What did you expect?

Enteting within the app and seeing an empty room list.

What happened instead?

I had to reset the identity on a fresh new account

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

Yes
@manuroe manuroe added T-Defect A-E2EE-Cross-Signing A-Authentication S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 7, 2024
@manuroe manuroe mentioned this issue Aug 7, 2024
Closed
stefanceriu added a commit that referenced this issue Aug 8, 2024
@stefanceriu
Fixes #3126 - Prevent identity confirmation from blocking the user's …
a5d36ff 
…progress after registering through OIDC
stefanceriu added a commit that referenced this issue Aug 8, 2024
@stefanceriu
Fixes #3126 - Prevent identity confirmation from blocking the user's …
0360123 
…progress after registering through OIDC

- happened because `hasRunIdentityConfirmationOnboarding` is false while the verification state is still `.unknown`
- verification eventually changes to `.verified` but the flow coordinator doesn't catch up on it and blocks the flow
@stefanceriu stefanceriu reopened this Sep 3, 2024
stefanceriu added a commit that referenced this issue Sep 3, 2024
@stefanceriu
Fixes #3126 - Prevent verification state changes other than `verified…
5f2ed07 
…` from blocking the user on the session verification screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Authentication A-E2EE-Cross-Signing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanceriu @manuroe