Sending a message when offline may silently lose the message #1726

ara4n · 2023-09-17T09:37:30Z

Steps to reproduce

Sent a message
Spotted that the app said “offline”
Went to room list
Went back
Message entirely lost forever

Outcome

What did you expect?

App should never lose msgs

What happened instead?

Bad queueing; lost msg.

https://github.com/vector-im/element-x-ios-rageshakes/issues/888

Your phone model

No response

Operating system version

No response

Application version

385

Homeserver

No response

Will you send logs?

Yes

jplatte · 2023-10-25T14:20:50Z

Is this still reproducible? (I think it shouldn't be)

Though keeping unsent messages across app restarts is still TODO.

kittykat · 2023-11-23T13:34:37Z

@jplatte 100% reproducible for me:

Switch on airplane mode
Go to my test room (created as a room, converted to DM, I am only member)
Send (2) message(s) - I was intending to test sequence
Switch off airplane mode
Watch both messages vanish

jplatte · 2023-11-23T13:37:47Z

When you say the messages vanished, do you mean no messages are displayed at all anymore? If yes, a rageshake would be helpful.

kittykat · 2023-11-23T13:46:18Z

@jplatte The two messages I tried to send from iOS went from being displayed as failed messages while I was in airplane mode to no longer being shown in the timeline at all once I switched off airplane mode. All other historical messages are still shown in the timeline. I can do a screen recording if that would be helpful?

jplatte · 2023-11-23T13:49:42Z

No, I don't think a screencast helps. Have you checked that the failed messages haven't "just" moved higher up though?

kittykat · 2023-11-23T13:51:00Z

@jplatte they move higher on Android, but on iOS, I cannot see them higher up

jplatte · 2023-11-23T13:54:52Z

That's even more confusing 🥲

I'll look at the rageshake soon.

jplatte · 2023-12-07T13:35:03Z

Rageshakes didn't contain that much info, matrix-org/matrix-rust-sdk#2887 should help for future rageshakes.

timokoesters · 2024-01-08T10:34:33Z

they move higher on Android, but on iOS, I cannot see them higher up

I cannot reproduce this on Android with the latest nightly, the messages stay where they are. Can you still reproduce it @kittykat ?

manuroe · 2024-01-08T14:41:38Z

EIX 1.5.2 nightly is also better for handling network retries when network is back. It also keeps the messages and moves it into sent failure after the timeout. So, I cannot reproduce anymore the bug in the scenario described at #1726 (comment).
However, moving back to the room list and reenter the room can lose the failed sent messages but it is not 100% reproductible. I do not know if it is a SDK or app only issue. Android seems not impacted by this problem.

ara4n · 2024-01-10T14:51:41Z

i just reproduced the 100% vanish bug. The app wasn't showing as offline and i was on 3 bars of 5G:

Sent two messages
They didn't send, for whatever reason - hollow circle
Wait 20s or so
Get bored and switch room
Switch back again: messges entirely gone. They had not jumped upwards 20 msgs.

Have rageshaked.

ara4n · 2024-01-10T15:23:32Z

they move higher on Android, but on iOS, I cannot see them higher up

to be clear, on iOS there is also the related-but-not-the-same bug that unsent messages can end up 'stuck' 20 msgs higher in the timeline: #1279

Velin92 · 2024-01-10T15:32:29Z

Does Android actually store the timeline/room instance even after the room is dismissed? @bmarty
Because iOS deallocates a room in the exact moment it is dismissed, which means that on the Rust side the queue for that room is actually also probably deallocated.
@timokoesters how does this bit work? https://github.com/matrix-org/matrix-rust-sdk/blob/9fd52e5df76f376519a0d27f727acc90144518d6/crates/matrix-sdk-ui/src/timeline/mod.rs#L295-L301
Does the timeline store the message immediately on the actual disk storage as soon as it gets put in the queue?

timokoesters · 2024-01-29T13:04:18Z

I tried to reproduce it with this patch, but it looks fine on Android. If someone wants to reproduce it on iOS, try this:

diff --git a/crates/matrix-sdk/src/room/futures.rs b/crates/matrix-sdk/src/room/futures.rs
index ebe2b6f05..8c2297c1f 100644
--- a/crates/matrix-sdk/src/room/futures.rs
+++ b/crates/matrix-sdk/src/room/futures.rs
@@ -36,7 +36,7 @@ use tracing::{debug, Instrument, Span};

 use super::Room;
 use crate::{
-    attachment::AttachmentConfig, utils::IntoRawMessageLikeEventContent, Result,
+    attachment::AttachmentConfig, utils::IntoRawMessageLikeEventContent, Error, Result,
     TransmissionProgress,
 };
 #[cfg(feature = "image-proc")]
@@ -200,8 +200,9 @@ impl<'a> IntoFuture for SendRawMessageLikeEvent<'a> {
                 content,
             );

-            let response = room.client.send(request, None).await?;
-            Ok(response)
+            Err(Error::NoOlmMachine) // Trigger an error
         };

         Box::pin(fut.instrument(tracing_span))

Velin92 · 2024-01-29T16:05:55Z

I tried to reproduce it with this patch, but it looks fine on Android. If someone wants to reproduce it on iOS, try this:

diff --git a/crates/matrix-sdk/src/room/futures.rs b/crates/matrix-sdk/src/room/futures.rs
index ebe2b6f05..8c2297c1f 100644
--- a/crates/matrix-sdk/src/room/futures.rs
+++ b/crates/matrix-sdk/src/room/futures.rs
@@ -36,7 +36,7 @@ use tracing::{debug, Instrument, Span};

 use super::Room;
 use crate::{
-    attachment::AttachmentConfig, utils::IntoRawMessageLikeEventContent, Result,
+    attachment::AttachmentConfig, utils::IntoRawMessageLikeEventContent, Error, Result,
     TransmissionProgress,
 };
 #[cfg(feature = "image-proc")]
@@ -200,8 +200,9 @@ impl<'a> IntoFuture for SendRawMessageLikeEvent<'a> {
                 content,
             );

-            let response = room.client.send(request, None).await?;
-            Ok(response)
+            Err(Error::NoOlmMachine) // Trigger an error
         };

         Box::pin(fut.instrument(tracing_span))

I'll give it a quick try, thanks

Velin92 · 2024-01-29T18:00:50Z

I investigate the issue a bit and this seems to be caused by the fact that we call the unsubscribe function from RoomListItem every time the room is removed from the navigation, which I mean makes total sense.
But as soon as we resubscribe to the room, and the timeline is generated again, but is removing all the unsent items.
Just to test this I tried with @timokoesters 's patch, sent a bunch of failed messages, and every time I was unsubscribing to a room, and resubscribing to it, the timeline was regenerated without the unsent items.
As soon as I stopped calling the unsubscribe function the messages were kept... however this is not ideal ofc.
From what I understand Android is also calling this function when exiting a room, so I really don't get why the issue is present only on iOS.
Maybe tomorrow we can't try to check this together @timokoesters

Velin92 · 2024-02-21T15:32:50Z

@manuroe @timokoesters
Btw opened this issue on the rust sdk repo:
matrix-org/matrix-rust-sdk#3152

This should fix the issue on iOS, and also fix the issue on both platforms that happens when we have unsent messages in the room, but we scroll down in the room list, removing the room from the SS window, which when re-entering deletes the unsent messages

stefanceriu · 2024-06-18T06:17:22Z

I believe this has been fixed with introduction of the new message sending queue. Please reopen if you see it again.

stefanceriu added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue A-Timeline T-Defect S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 4, 2023

kittykat added the Z-Schedule label Oct 11, 2023

kittykat added the A-Offline label Nov 23, 2023

kittykat mentioned this issue Nov 23, 2023

[Story] Show error: Message could not be send. Allow manual resend. element-hq/element-meta#1145

Open

3 tasks

jplatte self-assigned this Nov 23, 2023

jplatte removed their assignment Dec 7, 2023

manuroe removed the Z-Schedule label Jan 17, 2024

stefanceriu closed this as completed Jun 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sending a message when offline may silently lose the message #1726

Sending a message when offline may silently lose the message #1726

ara4n commented Sep 17, 2023

jplatte commented Oct 25, 2023 •

edited

Loading

kittykat commented Nov 23, 2023

jplatte commented Nov 23, 2023

kittykat commented Nov 23, 2023

jplatte commented Nov 23, 2023

kittykat commented Nov 23, 2023

jplatte commented Nov 23, 2023

jplatte commented Dec 7, 2023 •

edited

Loading

timokoesters commented Jan 8, 2024

manuroe commented Jan 8, 2024

ara4n commented Jan 10, 2024

ara4n commented Jan 10, 2024

Velin92 commented Jan 10, 2024 •

edited

Loading

timokoesters commented Jan 29, 2024

Velin92 commented Jan 29, 2024

Velin92 commented Jan 29, 2024 •

edited

Loading

Velin92 commented Feb 21, 2024 •

edited

Loading

stefanceriu commented Jun 18, 2024

Sending a message when offline may silently lose the message #1726

Sending a message when offline may silently lose the message #1726

Comments

ara4n commented Sep 17, 2023

Steps to reproduce

Outcome

What did you expect?

What happened instead?

Your phone model

Operating system version

Application version

Homeserver

Will you send logs?

jplatte commented Oct 25, 2023 • edited Loading

kittykat commented Nov 23, 2023

jplatte commented Nov 23, 2023

kittykat commented Nov 23, 2023

jplatte commented Nov 23, 2023

kittykat commented Nov 23, 2023

jplatte commented Nov 23, 2023

jplatte commented Dec 7, 2023 • edited Loading

timokoesters commented Jan 8, 2024

manuroe commented Jan 8, 2024

ara4n commented Jan 10, 2024

ara4n commented Jan 10, 2024

Velin92 commented Jan 10, 2024 • edited Loading

timokoesters commented Jan 29, 2024

Velin92 commented Jan 29, 2024

Velin92 commented Jan 29, 2024 • edited Loading

Velin92 commented Feb 21, 2024 • edited Loading

stefanceriu commented Jun 18, 2024

jplatte commented Oct 25, 2023 •

edited

Loading

jplatte commented Dec 7, 2023 •

edited

Loading

Velin92 commented Jan 10, 2024 •

edited

Loading

Velin92 commented Jan 29, 2024 •

edited

Loading

Velin92 commented Feb 21, 2024 •

edited

Loading