knock requests list tests

element-hq · Dec 13, 2024 · 8eb5f82 · 8eb5f82
1 parent 36bfd18
commit 8eb5f82
Show file tree

Hide file tree

Showing 13 changed files with 247 additions and 10 deletions.
diff --git a/ElementX/Sources/Screens/KnockRequestsListScreen/KnockRequestsListScreenViewModel.swift b/ElementX/Sources/Screens/KnockRequestsListScreen/KnockRequestsListScreenViewModel.swift
@@ -56,8 +56,7 @@ class KnockRequestsListScreenViewModel: KnockRequestsListScreenViewModelType, Kn
                                              title: L10n.screenKnockRequestsListDeclineAlertTitle,
                                              message: L10n.screenKnockRequestsListDeclineAlertDescription(request.userID),
                                              primaryButton: .init(title: L10n.screenKnockRequestsListDeclineAlertConfirmButtonTitle,
-                                                                  role: .destructive,
-                                                                  action: { [weak self] in self?.decline(request: request) }),
+                                                                  role: .destructive) { [weak self] in self?.decline(request: request) },
                                              secondaryButton: .init(title: L10n.actionCancel, role: .cancel, action: nil))
         case .ban(let eventID):
             guard let request = getRequest(eventID: eventID) else {
@@ -67,8 +66,7 @@ class KnockRequestsListScreenViewModel: KnockRequestsListScreenViewModelType, Kn
             state.bindings.alertInfo = .init(id: .declineAndBan,
                                              title: L10n.screenKnockRequestsListBanAlertTitle,
                                              primaryButton: .init(title: L10n.screenKnockRequestsListBanAlertConfirmButtonTitle,
-                                                                  role: .destructive,
-                                                                  action: { [weak self] in self?.declineAndBan(request: request) }),
+                                                                  role: .destructive) { [weak self] in self?.declineAndBan(request: request) },
                                              secondaryButton: .init(title: L10n.actionCancel, role: .cancel, action: nil))
         }
     }

diff --git a/ElementX/Sources/Screens/KnockRequestsListScreen/View/KnockRequestsListScreen.swift b/ElementX/Sources/Screens/KnockRequestsListScreen/View/KnockRequestsListScreen.swift
@@ -88,7 +88,10 @@ struct KnockRequestsListScreen_Previews: PreviewProvider, TestablePreview {
 
     static let emptyViewModel = KnockRequestsListScreenViewModel.mockWithRequestsState(.loaded([]))
 
+    static let singleRequestViewModel = KnockRequestsListScreenViewModel.mockWithRequestsState(.loaded([JoinRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org", displayName: "Alice", avatarURL: nil, timestamp: "Now", reason: "Hello"))]))
+
     static let viewModel = KnockRequestsListScreenViewModel.mockWithRequestsState(.loaded([JoinRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org", displayName: "Alice", avatarURL: nil, timestamp: "Now", reason: "Hello")),
+                                                                                           // swiftlint:disable:next line_length
                                                                                            JoinRequestProxyMock(.init(eventID: "2", userID: "@bob:matrix.org", displayName: "Bob", avatarURL: nil, timestamp: "Now", reason: "Hello this one is a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long reason")),
                                                                                            JoinRequestProxyMock(.init(eventID: "3", userID: "@charlie:matrix.org", displayName: "Charlie", avatarURL: nil, timestamp: "Now", reason: nil)),
                                                                                            JoinRequestProxyMock(.init(eventID: "4", userID: "@dan:matrix.org", displayName: "Dan", avatarURL: nil, timestamp: "Now", reason: "Hello! It's a me! Dan!"))]))
@@ -97,10 +100,20 @@ struct KnockRequestsListScreen_Previews: PreviewProvider, TestablePreview {
         NavigationStack {
             KnockRequestsListScreen(context: viewModel.context)
         }
+        .snapshotPreferences(delay: 0.2)
+
+        NavigationStack {
+            KnockRequestsListScreen(context: singleRequestViewModel.context)
+        }
+        .previewDisplayName("Single Request")
+        .snapshotPreferences(delay: 0.2)
+
         NavigationStack {
             KnockRequestsListScreen(context: emptyViewModel.context)
         }
         .previewDisplayName("Empty state")
+        .snapshotPreferences(delay: 0.2)
+
         NavigationStack {
             KnockRequestsListScreen(context: loadingViewModel.context)
         }

diff --git a/ElementX/Sources/Screens/RoomScreen/View/KnockRequestsBannerView.swift b/ElementX/Sources/Screens/RoomScreen/View/KnockRequestsBannerView.swift
@@ -103,10 +103,8 @@ private struct SingleKnockRequestBannerContent: View {
             Button(L10n.screenRoomSingleKnockRequestViewButtonTitle, action: onViewAll)
                 .buttonStyle(.compound(.secondary, size: .medium))
             if let onAccept {
-                Button(L10n.screenRoomSingleKnockRequestAcceptButtonTitle, action: {
-                    onAccept(request.eventID)
-                })
-                .buttonStyle(.compound(.primary, size: .medium))
+                Button(L10n.screenRoomSingleKnockRequestAcceptButtonTitle) { onAccept(request.eventID) }
+                    .buttonStyle(.compound(.primary, size: .medium))
             }
         }
         .padding(.top, request.reason == nil ? 0 : 2)

diff --git a/...pshots__/PreviewTests/test_knockRequestsListScreen-iPad-en-GB.Loading-state.png b/...pshots__/PreviewTests/test_knockRequestsListScreen-iPad-en-GB.Loading-state.png
diff --git a/...shots__/PreviewTests/test_knockRequestsListScreen-iPad-en-GB.Single-Request.png b/...shots__/PreviewTests/test_knockRequestsListScreen-iPad-en-GB.Single-Request.png
diff --git a/...shots__/PreviewTests/test_knockRequestsListScreen-iPad-pseudo.Loading-state.png b/...shots__/PreviewTests/test_knockRequestsListScreen-iPad-pseudo.Loading-state.png
diff --git a/...hots__/PreviewTests/test_knockRequestsListScreen-iPad-pseudo.Single-Request.png b/...hots__/PreviewTests/test_knockRequestsListScreen-iPad-pseudo.Single-Request.png
diff --git a/...s__/PreviewTests/test_knockRequestsListScreen-iPhone-16-en-GB.Loading-state.png b/...s__/PreviewTests/test_knockRequestsListScreen-iPhone-16-en-GB.Loading-state.png
diff --git a/...__/PreviewTests/test_knockRequestsListScreen-iPhone-16-en-GB.Single-Request.png b/...__/PreviewTests/test_knockRequestsListScreen-iPhone-16-en-GB.Single-Request.png
diff --git a/...__/PreviewTests/test_knockRequestsListScreen-iPhone-16-pseudo.Loading-state.png b/...__/PreviewTests/test_knockRequestsListScreen-iPhone-16-pseudo.Loading-state.png
diff --git a/..._/PreviewTests/test_knockRequestsListScreen-iPhone-16-pseudo.Single-Request.png b/..._/PreviewTests/test_knockRequestsListScreen-iPhone-16-pseudo.Single-Request.png
diff --git a/UnitTests/Sources/KnockRequestsListScreenViewModelTests.swift b/UnitTests/Sources/KnockRequestsListScreenViewModelTests.swift
@@ -18,8 +18,209 @@ class KnockRequestsListScreenViewModelTests: XCTestCase {
     }
 
     override func setUpWithError() throws {
-        viewModel = KnockRequestsListScreenViewModel(roomProxy: JoinedRoomProxyMock(.init()),
+        AppSettings.resetAllSettings()
+    }
+
+    func testLoadingState() async throws {
+        let roomProxyMock = JoinedRoomProxyMock(.init(joinRequestsState: .loading, joinRule: .knock))
+        viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
+                                                     mediaProvider: MediaProviderMock(),
+                                                     userIndicatorController: UserIndicatorControllerMock())
+
+        let deferred = deferFulfillment(context.$viewState) { state in
+            !state.shouldDisplayRequests &&
+                state.isKnockableRoom &&
+                state.canAccept &&
+                !state.canBan &&
+                !state.canDecline &&
+                state.isLoading &&
+                !state.shouldDisplayEmptyView
+        }
+        try await deferred.fulfill()
+    }
+
+    func testEmptyState() async throws {
+        let roomProxyMock = JoinedRoomProxyMock(.init(joinRequestsState: .loaded([]), joinRule: .knock))
+        viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
+                                                     mediaProvider: MediaProviderMock(),
+                                                     userIndicatorController: UserIndicatorControllerMock())
+
+        let deferred = deferFulfillment(context.$viewState) { state in
+            !state.shouldDisplayRequests &&
+                state.isKnockableRoom &&
+                state.canAccept &&
+                !state.canBan &&
+                !state.canDecline &&
+                !state.isLoading &&
+                state.shouldDisplayEmptyView
+        }
+        try await deferred.fulfill()
+    }
+
+    func testLoadedState() async throws {
+        let roomProxyMock = JoinedRoomProxyMock(.init(members: [.mockAdmin],
+                                                      joinRequestsState: .loaded([JoinRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "2", userID: "@bob:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "3", userID: "@charlie:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "4", userID: "@dan:matrix.org"))]),
+                                                      ownUserID: RoomMemberProxyMock.mockAdmin.userID,
+                                                      joinRule: .knock))
+        viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
+                                                     mediaProvider: MediaProviderMock(),
+                                                     userIndicatorController: UserIndicatorControllerMock())
+
+        var deferred = deferFulfillment(context.$viewState) { state in
+            state.shouldDisplayRequests &&
+                state.isKnockableRoom &&
+                state.canAccept &&
+                state.canBan &&
+                state.canDecline &&
+                !state.isLoading &&
+                !state.shouldDisplayEmptyView &&
+                state.displayedRequests.count == 4 &&
+                state.handledEventIDs.isEmpty &&
+                state.shouldDisplayAcceptAllButton
+        }
+        try await deferred.fulfill()
+
+        deferred = deferFulfillment(context.$viewState) { state in
+            state.shouldDisplayRequests &&
+                state.handledEventIDs == ["1"] &&
+                !state.shouldDisplayEmptyView &&
+                state.displayedRequests.count == 3 &&
+                state.shouldDisplayAcceptAllButton
+        }
+        context.send(viewAction: .acceptRequest(eventID: "1"))
+        try await deferred.fulfill()
+
+        deferred = deferFulfillment(context.$viewState) { state in
+            state.bindings.alertInfo?.id == .declineRequest
+        }
+        context.send(viewAction: .declineRequest(eventID: "2"))
+        try await deferred.fulfill()
+
+        guard let declineAlertInfo = context.alertInfo else {
+            XCTFail("Can't be nil")
+            return
+        }
+        deferred = deferFulfillment(context.$viewState) { state in
+            state.shouldDisplayRequests &&
+                state.handledEventIDs == ["1", "2"] &&
+                !state.shouldDisplayEmptyView &&
+                state.displayedRequests.count == 2 &&
+                state.shouldDisplayAcceptAllButton
+        }
+        declineAlertInfo.primaryButton.action?()
+        try await deferred.fulfill()
+
+        deferred = deferFulfillment(context.$viewState) { state in
+            state.bindings.alertInfo?.id == .declineAndBan
+        }
+        context.send(viewAction: .ban(eventID: "3"))
+        try await deferred.fulfill()
+
+        guard let banAlertInfo = context.alertInfo else {
+            XCTFail("Can't be nil")
+            return
+        }
+        deferred = deferFulfillment(context.$viewState) { state in
+            state.shouldDisplayRequests &&
+                state.handledEventIDs == ["1", "2", "3"] &&
+                !state.shouldDisplayEmptyView &&
+                state.displayedRequests.count == 1 &&
+                !state.shouldDisplayAcceptAllButton
+        }
+        banAlertInfo.primaryButton.action?()
+        try await deferred.fulfill()
+    }
+
+    func testAcceptAll() async throws {
+        let roomProxyMock = JoinedRoomProxyMock(.init(joinRequestsState: .loaded([JoinRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "2", userID: "@bob:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "3", userID: "@charlie:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "4", userID: "@dan:matrix.org"))]),
+                                                      joinRule: .knock))
+        viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
+                                                     mediaProvider: MediaProviderMock(),
+                                                     userIndicatorController: UserIndicatorControllerMock())
+
+        var deferred = deferFulfillment(context.$viewState) { state in
+            state.shouldDisplayRequests &&
+                state.isKnockableRoom &&
+                state.canAccept &&
+                !state.canBan &&
+                !state.canDecline &&
+                !state.isLoading &&
+                !state.shouldDisplayEmptyView &&
+                state.displayedRequests.count == 4 &&
+                state.handledEventIDs.isEmpty &&
+                state.shouldDisplayAcceptAllButton
+        }
+        try await deferred.fulfill()
+
+        deferred = deferFulfillment(context.$viewState) { state in
+            state.bindings.alertInfo?.id == .acceptAllRequests
+        }
+        context.send(viewAction: .acceptAllRequests)
+        try await deferred.fulfill()
+
+        guard let alertInfo = context.alertInfo else {
+            XCTFail("Can't be nil")
+            return
+        }
+
+        deferred = deferFulfillment(context.$viewState) { state in
+            !state.shouldDisplayRequests &&
+                state.handledEventIDs == ["1", "2", "3", "4"] &&
+                !state.isLoading &&
+                state.shouldDisplayEmptyView
+        }
+        alertInfo.primaryButton.action?()
+        try await deferred.fulfill()
+    }
+
+    func testLoadedStateBecomesEmptyIfTheJoinRuleIsNotKnocking() async throws {
+        // If there is a sudden change in the rule, but the requests are still published, we want to hide all of them and show the empty view
+        let roomProxyMock = JoinedRoomProxyMock(.init(members: [.mockAdmin],
+                                                      joinRequestsState: .loaded([JoinRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "2", userID: "@bob:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "3", userID: "@charlie:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "4", userID: "@dan:matrix.org"))]),
+                                                      ownUserID: RoomMemberProxyMock.mockAdmin.userID,
+                                                      joinRule: .invite))
+        viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
+                                                     mediaProvider: MediaProviderMock(),
+                                                     userIndicatorController: UserIndicatorControllerMock())
+
+        let deferred = deferFulfillment(context.$viewState) { state in
+            !state.shouldDisplayRequests &&
+                state.shouldDisplayEmptyView &&
+                !state.isLoading &&
+                !state.isKnockableRoom
+        }
+        try await deferred.fulfill()
+    }
+
+    func testLoadedStateBecomesEmptyIfPermissionsAreRemoved() async throws {
+        // If there is a sudden change in permissions, and the user can't do any other action, we hide all the requests and shoe the empty view
+        let roomProxyMock = JoinedRoomProxyMock(.init(joinRequestsState: .loaded([JoinRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "2", userID: "@bob:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "3", userID: "@charlie:matrix.org")),
+                                                                                  JoinRequestProxyMock(.init(eventID: "4", userID: "@dan:matrix.org"))]),
+                                                      canUserInvite: false,
+                                                      joinRule: .knock))
+        viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
                                                      mediaProvider: MediaProviderMock(),
                                                      userIndicatorController: UserIndicatorControllerMock())
+
+        let deferred = deferFulfillment(context.$viewState) { state in
+            !state.shouldDisplayRequests &&
+                state.shouldDisplayEmptyView &&
+                !state.canAccept &&
+                !state.canBan &&
+                !state.canDecline &&
+                !state.isLoading
+        }
+        try await deferred.fulfill()
     }
 }
diff --git a/UnitTests/Sources/RoomDetailsViewModelTests.swift b/UnitTests/Sources/RoomDetailsViewModelTests.swift
@@ -691,8 +691,11 @@ class RoomDetailsScreenViewModelTests: XCTestCase {
         let deferred = deferFulfillment(context.$viewState) { state in
             state.knockRequestsCount == 2 && state.canSeeKnockingRequests
         }
-
         try await deferred.fulfill()
+
+        let deferredAction = deferFulfillment(viewModel.actions) { $0 == .displayKnockingRequests }
+        context.send(viewAction: .processTapRequestsToJoin)
+        try await deferredAction.fulfill()
     }
 
     func testKnockRequestsCounterIsLoading() async throws {