Move notifyOtherParticipants to the ElementCallConfiguration.

ElementX/Sources/Application/AppCoordinator.swift

@@ -658,7 +658,6 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationFlowCoordinatorDeleg
         let callScreenCoordinator = CallScreenCoordinator(parameters: .init(elementCallService: elementCallService,
                                                                             configuration: configuration,
                                                                             allowPictureInPicture: false,
-                                                                            notifyOtherParticipants: false,
                                                                             appHooks: appHooks))
 
         callScreenCoordinator.actions

ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift

@@ -655,7 +655,7 @@ class UserSessionFlowCoordinator: FlowCoordinatorProtocol {
     // MARK: Calls
 
     private func presentCallScreen(genericCallLink url: URL) {
-        presentCallScreen(configuration: .init(genericCallLink: url), notifyOtherParticipants: false)
+        presentCallScreen(configuration: .init(genericCallLink: url))
     }
 
     private func presentCallScreen(roomID: String, notifyOtherParticipants: Bool) async {
@@ -673,12 +673,12 @@ class UserSessionFlowCoordinator: FlowCoordinatorProtocol {
                                                clientID: InfoPlistReader.main.bundleIdentifier,
                                                elementCallBaseURL: appSettings.elementCallBaseURL,
                                                elementCallBaseURLOverride: appSettings.elementCallBaseURLOverride,
-                                               colorScheme: colorScheme),
-                          notifyOtherParticipants: notifyOtherParticipants)
+                                               colorScheme: colorScheme,
+                                               notifyOtherParticipants: notifyOtherParticipants))
     }
 
     private var callScreenPictureInPictureController: AVPictureInPictureController?
-    private func presentCallScreen(configuration: ElementCallConfiguration, notifyOtherParticipants: Bool) {
+    private func presentCallScreen(configuration: ElementCallConfiguration) {
         guard elementCallService.ongoingCallRoomIDPublisher.value != configuration.callRoomID else {
             MXLog.info("Returning to existing call.")
             callScreenPictureInPictureController?.stopPictureInPicture()
@@ -688,7 +688,6 @@ class UserSessionFlowCoordinator: FlowCoordinatorProtocol {
         let callScreenCoordinator = CallScreenCoordinator(parameters: .init(elementCallService: elementCallService,
                                                                             configuration: configuration,
                                                                             allowPictureInPicture: true,
-                                                                            notifyOtherParticipants: notifyOtherParticipants,
                                                                             appHooks: appHooks))
 
         callScreenCoordinator.actions

ElementX/Sources/Screens/CallScreen/CallScreenCoordinator.swift

@@ -13,7 +13,6 @@ struct CallScreenCoordinatorParameters {
     let elementCallService: ElementCallServiceProtocol
     let configuration: ElementCallConfiguration
     let allowPictureInPicture: Bool
-    let notifyOtherParticipants: Bool
     let appHooks: AppHooks
 }
 
@@ -44,7 +43,6 @@ final class CallScreenCoordinator: CoordinatorProtocol {
         viewModel = CallScreenViewModel(elementCallService: parameters.elementCallService,
                                         configuration: parameters.configuration,
                                         allowPictureInPicture: parameters.allowPictureInPicture,
-                                        notifyOtherParticipants: parameters.notifyOtherParticipants,
                                         appHooks: parameters.appHooks)
     }
 

ElementX/Sources/Screens/CallScreen/CallScreenViewModel.swift

@@ -33,7 +33,6 @@ class CallScreenViewModel: CallScreenViewModelType, CallScreenViewModelProtocol
     init(elementCallService: ElementCallServiceProtocol,
          configuration: ElementCallConfiguration,
          allowPictureInPicture: Bool,
-         notifyOtherParticipants: Bool,
          appHooks: AppHooks) {
         self.elementCallService = elementCallService
         self.configuration = configuration
@@ -42,7 +41,7 @@ class CallScreenViewModel: CallScreenViewModelType, CallScreenViewModelProtocol
         switch configuration.kind {
         case .genericCallLink(let url):
             widgetDriver = GenericCallLinkWidgetDriver(url: url)
-        case .roomCall(let roomProxy, let clientProxy, _, _, _, _):
+        case .roomCall(let roomProxy, let clientProxy, _, _, _, _, _):
             guard let deviceID = clientProxy.deviceID else { fatalError("Missing device ID for the call.") }
             widgetDriver = roomProxy.elementCallWidgetDriver(deviceID: deviceID)
         }
@@ -102,7 +101,7 @@ class CallScreenViewModel: CallScreenViewModelType, CallScreenViewModelProtocol
             }
             .store(in: &cancellables)
 
-        setupCall(notifyOtherParticipants: notifyOtherParticipants)
+        setupCall()
     }
 
     override func process(viewAction: CallScreenViewAction) {
@@ -131,13 +130,13 @@ class CallScreenViewModel: CallScreenViewModelType, CallScreenViewModelProtocol
 
     // MARK: - Private
 
-    private func setupCall(notifyOtherParticipants: Bool) {
+    private func setupCall() {
         switch configuration.kind {
         case .genericCallLink(let url):
             state.url = url
             // We need widget messaging to work before enabling CallKit, otherwise mute, hangup etc do nothing.
 
-        case .roomCall(let roomProxy, let clientProxy, let clientID, let elementCallBaseURL, let elementCallBaseURLOverride, let colorScheme):
+        case .roomCall(let roomProxy, let clientProxy, let clientID, let elementCallBaseURL, let elementCallBaseURLOverride, let colorScheme, let notifyOtherParticipants):
             Task { [weak self] in
                 guard let self else { return }
 

ElementX/Sources/Screens/CallScreen/View/CallScreen.swift

@@ -303,9 +303,9 @@ struct CallScreen_Previews: PreviewProvider {
                                                         clientID: "io.element.elementx",
                                                         elementCallBaseURL: "https://call.element.io",
                                                         elementCallBaseURLOverride: nil,
-                                                        colorScheme: .light),
+                                                        colorScheme: .light,
+                                                        notifyOtherParticipants: false),
                                    allowPictureInPicture: false,
-                                   notifyOtherParticipants: false,
                                    appHooks: AppHooks())
     }()
 

ElementX/Sources/Services/ElementCall/ElementCallConfiguration.swift

@@ -21,7 +21,8 @@ struct ElementCallConfiguration {
                       clientID: String,
                       elementCallBaseURL: URL,
                       elementCallBaseURLOverride: URL?,
-                      colorScheme: ColorScheme)
+                      colorScheme: ColorScheme,
+                      notifyOtherParticipants: Bool)
     }
 
     /// The type of call being configured i.e. whether it's an external URL or an internal room call.
@@ -58,21 +59,23 @@ struct ElementCallConfiguration {
          clientID: String,
          elementCallBaseURL: URL,
          elementCallBaseURLOverride: URL?,
-         colorScheme: ColorScheme) {
+         colorScheme: ColorScheme,
+         notifyOtherParticipants: Bool) {
         kind = .roomCall(roomProxy: roomProxy,
                          clientProxy: clientProxy,
                          clientID: clientID,
                          elementCallBaseURL: elementCallBaseURL,
                          elementCallBaseURLOverride: elementCallBaseURLOverride,
-                         colorScheme: colorScheme)
+                         colorScheme: colorScheme,
+                         notifyOtherParticipants: notifyOtherParticipants)
     }
 
     /// A string representing the call being configured.
     var callRoomID: String {
         switch kind {
         case .genericCallLink(let url):
             url.absoluteString
-        case .roomCall(let roomProxy, _, _, _, _, _):
+        case .roomCall(let roomProxy, _, _, _, _, _, _):
             roomProxy.id
         }
     }