Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTE: Bad things happen when you send emoji #1394

Closed
ara4n opened this issue Sep 20, 2023 · 0 comments · Fixed by #1447
Closed

RTE: Bad things happen when you send emoji #1394

ara4n opened this issue Sep 20, 2023 · 0 comments · Fixed by #1447
Labels
A-Rich-Text-Editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Element X Feature

Comments

@ara4n
Copy link
Member

ara4n commented Sep 20, 2023

Steps to reproduce

  • In RTE, send some formatting, then an emoji
  • formatting gets lost
  • linebreaks get lost too?
  • possibly other badness shown on the video below

Video taken from etherhaus here

screen-20230920-201649.mp4

Outcome

What did you expect?

ability to mix emoji & formatted text in RTE

What happened instead?

"Text gains life"

Your phone model

No response

Operating system version

No response

Application version and app store

0.2.0

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No
@ara4n ara4n added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Sep 20, 2023
@jonnyandrew jonnyandrew added A-Rich-Text-Editor S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Team: Element X Feature labels Sep 21, 2023
This was referenced Sep 26, 2023
Closed
Merged
Merged
jonnyandrew added a commit that referenced this issue Sep 29, 2023
@jonnyandrew
[Rich text editor] Add full screen mode (#1447)
53cf82f 
- Add full screen mode for the rich text editor (RTE). When text formatting options are enabled, the editor can be dragged to full screen.
- Remove `ConstraintLayout` from `textcomposer` module, now made much simpler now the RTE supports being called in multiple layouts matrix-org/matrix-rich-text-editor#822

- Part of element-hq/element-meta#1973
- Includes design from #1315
- Fixes #1293 (through new layout)
- Fixes #1394 (through inclusion of matrix-org/matrix-rich-text-editor#824)
- Fixes #1259 (through inclusion of matrix-org/matrix-rich-text-editor#820)

---------

Co-authored-by: ElementBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rich-Text-Editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Element X Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Rich text editor] Add full screen mode element-hq/element-x-android
2 participants
@ara4n @jonnyandrew