Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replies styling #6117

Closed
wants to merge 19 commits into from
Closed

Replies styling #6117

wants to merge 19 commits into from

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 10, 2018

@lukebarnard1 lukebarnard1 self-assigned this Feb 16, 2018
Copy link
Contributor

@lukebarnard1 lukebarnard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm slightly cautious about all the :not(...)

I wonder if @ara4n has thoughts on this.

@t3chguy
Copy link
Member Author

t3chguy commented Feb 16, 2018

I'll take a look if it'll make sense to make the classes exclusive, i.e either a _line or a _reply and have boolean OR selectors instead

@lukebarnard1
Copy link
Contributor

ok, this looks easier to read to me, let's ask @ara4n what he thinks an upcoming sync

@t3chguy
Copy link
Member Author

t3chguy commented Apr 20, 2018

No longer required due to the GREAT RELAYERING, now all these changes have been moved to react-sdk

@t3chguy t3chguy closed this Apr 20, 2018
@t3chguy t3chguy deleted the t3chguy/m.relates_to branch May 2, 2018 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants