Use unread count for room highlight state #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - blocked on other PR before merging. |
…ld be unnecessary because the additional sizes are muxed into the ico file.
|
this has changed so quick ptal then I'll merge? |
| @@ -255,7 +255,7 @@ var RoomSubList = React.createClass({ | |||
| collapsed={ self.props.collapsed || false} | |||
| selected={ selected } | |||
| unread={ self.props.activityMap[room.roomId] === 1 } | |||
| highlight={ self.props.activityMap[room.roomId] === 2 } | |||
| highlight={ (room.unread_notifications && room.unread_notifications['notification_count'] > 0) || self.props.label === 'Invites' } | |||
There was a problem hiding this comment.
I thought we had getters for this now?
|
LGTM aside from comment |
|
ahem apply patch the right branch... |
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "default_hs_url": "https://matrix.org", | |||
| "default_hs_url": "http://localhost:8008", | |||
|
LGTM aside from config thing |
dbkr
added a commit
that referenced
this pull request
Jan 21, 2016
Use unread count for room highlight state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-react-sdk#68