Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some style improvements to autocompletions #4456

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Add some style improvements to autocompletions #4456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/skins/vector/css/matrix-react-sdk/views/rooms/_Autocomplete.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,29 @@
.mx_Autocomplete_Completion_pill {
border-radius: 17px;
height: 34px;
padding: 0px 5px;
display: flex;
user-select: none;
cursor: pointer;
align-items: center;
color: $primary-fg-color;
}

.mx_Autocomplete_Completion_pill * {
.mx_Autocomplete_Completion_pill > * {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I slightly question whether being in an autocomplete pill implies things will want this CSS, or whether it would be better to put this on the children directly, but if this works then fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was the original intention. I think it's only worth changing if there's a child that doesn't want a margin, which for the time being there isn't 😇

margin: 0 3px;
}

.mx_Autocomplete_provider_name,
.mx_Autocomplete_Completion_title,
.mx_Autocomplete_Completion_subtitle,
.mx_Autocomplete_Completion_description {
/* Ellipsis for long names/subtitles/descriptions*/
max-width: 150px;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}

/* container for pill-style completions */
.mx_Autocomplete_Completion_container_pill {
margin: 12px;
Expand Down