Test that we handle stored mx_last_room_id correctly #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do we show the last room correctly on resume? * Do we show the home page if we have no last room? * If we follow a login link, and re-log-in, do we correctly vape the mx_last_room_id (#4283)
| @@ -271,9 +245,30 @@ describe('loading:', function () { | |||
| localStorage.setItem("mx_is_url", "http://localhost" ); | |||
| localStorage.setItem("mx_access_token", "access_token"); | |||
| localStorage.setItem("mx_user_id", "@me:localhost"); | |||
| localStorage.setItem("mx_last_room_id", "!last_room:id"); | |||
There was a problem hiding this comment.
I'm not sure I like the fact that these tests rely on each other... Could this be moved to the start of the next test?
There was a problem hiding this comment.
this is a beforeEach, not a test?
There was a problem hiding this comment.
Oh! That's fine then :)
Ah yes. That's because of the magic where we use the same-named branch of react-sdk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fail until the corresponding matrix-react-sdk PR lands.