Functionality to speed up room list, mk II #3933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbkr I think we still need to resurrect the "don't rerender all of LeftPanel when we change room" bit out of this? |
|
we should now not re-render all of LeftPanel, if anything we may still need to pull out the logic to make it not re-render LeftPanel when a new event arrives? |
|
The react-sdk side of this has been closed, and the room list itself has changed quite a lot since this PR was opened. If there's room for improvement, it would be good to have an issue filed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3654 and related fixes
Requires matrix-org/matrix-react-sdk#895