-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a after timestamp #3046
Conversation
This solves part of the problem that the timestamp is gluing at the message, when copied in your clipboard. Example: 23:02test message see element-hq#893
what browser does this problem occur on? i don't see the timestamp glued to the message when copying from chrome... |
Yes, in Chrome it seems fine, in Firefox it is glued. |
Sorry again that this has got missed for almost a year. It's against the wrong branch though and you need to do the DCO signoff. |
Can't you please just cherry pick it from here? |
@rubo77 |
I changed to master. Hereby I sign the DCO |
It should be on |
@rubo77 please read the Contributing doc properly: https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off |
Sorry, I'm only on mobile until Monday |
Is the sign off on the first post correct? |
@@ -29,8 +29,10 @@ module.exports = React.createClass({ | |||
render: function() { | |||
const date = new Date(this.props.ts); | |||
return ( | |||
<span className="mx_MessageTimestamp"> | |||
{ DateUtils.formatTime(date)+' ' } | |||
<span className="mx_MessageTimestamp" title={ DateUtils.formatFullDate(date, this.props.showTwelveHour) }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a bad merge @dbkr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, good spot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM merge-wise
This solves part of the problem that the timestamp is gluing at the message, when copied in your clipboard.
Example:
see #893
Signed-off-by: Ruben Barkow [email protected]