-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic close-to-tray support for windows and linux #2960
Conversation
…ing multiple times; instead of starting the running instance is shown/focused
Sorry, github seems to automatically assuming all commits are part of the pull-request. Didn't know i needed to make seperate feature/bugfix branches. All commits are tray related except 6c9d908 |
…e hidden in the tray now)
Unity/GNOME3 need the following in the .desktop file to properly handle hidden windows: // package.json build.linux
"desktop": {
"StartupWMClass": "riot"
} Infos: http://askubuntu.com/questions/367396/what-represent-the-startupwmclass-field-of-a-desktop-file |
There was some discussion about how much backlash we'll get by making Riot always stay open in the background (ie. adding this with no way to turn it off), but the conclusion is that you can always choose the quit it, but without this you can't choose to have it run in the background. I'm going to try & merge this separately, with the relevant commits. @carlos22 can you do the DCO signoff as-per https://github.com/vector-im/riot-web/blob/master/CONTRIBUTING.rst please? |
If you want I can make a new clean pull request. Didn't know that github will include everything in my forked branch. |
Signed-off-by: Karl Glatz [email protected] |
Merge the notification part of #2960 * Show and focus the window when the notification is clicked, rather than just restoring it. * Implement requestNotificationPermission and return a resolved promise (although in practice it should never be called)
From #2960 Makes riot minimise to the tray on windows / linux.
Right, this should all now be PRed in the various PRs listed above! |
Merge the notification part of element-hq#2960 * Show and focus the window when the notification is clicked, rather than just restoring it. * Implement requestNotificationPermission and return a resolved promise (although in practice it should never be called)
From element-hq#2960 Makes riot minimise to the tray on windows / linux.
Creates a tray icon on windows and linux (or: not mac) and keeps the application running in the background when the user closes the window (close-to-tray). There is no configuration support yet.
See issue #2799
Signed-off-by: Karl Glatz [email protected]