Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic close-to-tray support for windows and linux #2960

Closed
wants to merge 4 commits into from

Conversation

carlos22
Copy link

@carlos22 carlos22 commented Jan 16, 2017

Creates a tray icon on windows and linux (or: not mac) and keeps the application running in the background when the user closes the window (close-to-tray). There is no configuration support yet.

See issue #2799

Signed-off-by: Karl Glatz [email protected]

@carlos22
Copy link
Author

carlos22 commented Jan 16, 2017

Sorry, github seems to automatically assuming all commits are part of the pull-request. Didn't know i needed to make seperate feature/bugfix branches. All commits are tray related except 6c9d908

@carlos22
Copy link
Author

carlos22 commented Jan 16, 2017

Unity/GNOME3 need the following in the .desktop file to properly handle hidden windows:

      // package.json build.linux
      "desktop": {
          "StartupWMClass": "riot"
       }

Infos: http://askubuntu.com/questions/367396/what-represent-the-startupwmclass-field-of-a-desktop-file

@dbkr
Copy link
Member

dbkr commented Jan 18, 2017

There was some discussion about how much backlash we'll get by making Riot always stay open in the background (ie. adding this with no way to turn it off), but the conclusion is that you can always choose the quit it, but without this you can't choose to have it run in the background.

I'm going to try & merge this separately, with the relevant commits. @carlos22 can you do the DCO signoff as-per https://github.com/vector-im/riot-web/blob/master/CONTRIBUTING.rst please?

@carlos22
Copy link
Author

carlos22 commented Jan 18, 2017

If you want I can make a new clean pull request. Didn't know that github will include everything in my forked branch.

@carlos22
Copy link
Author

Signed-off-by: Karl Glatz [email protected]

dbkr added a commit that referenced this pull request Jan 19, 2017
Merge the notification part of #2960

 * Show and focus the window when the notification is clicked,
   rather than just restoring it.
 * Implement requestNotificationPermission and return a resolved
   promise (although in practice it should never be called)
dbkr added a commit that referenced this pull request Jan 19, 2017
From #2960

Makes riot minimise to the tray on windows / linux.
This was referenced Jan 19, 2017
@dbkr
Copy link
Member

dbkr commented Jan 19, 2017

Right, this should all now be PRed in the various PRs listed above!

@dbkr dbkr closed this Jan 19, 2017
Half-Shot pushed a commit to Half-Shot/riot-web that referenced this pull request Feb 9, 2017
Merge the notification part of element-hq#2960

 * Show and focus the window when the notification is clicked,
   rather than just restoring it.
 * Implement requestNotificationPermission and return a resolved
   promise (although in practice it should never be called)
Half-Shot pushed a commit to Half-Shot/riot-web that referenced this pull request Feb 9, 2017
From element-hq#2960

Makes riot minimise to the tray on windows / linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants